Skip to content

Normalize Feature IDs to lowercase #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Normalize Feature IDs to lowercase #597

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
737af3c
normalize Feature Ids to lowercase (https://github.com/devcontainers/…
joshspicer Jul 18, 2023
0fba6e0
ensure userFeatureIds resolved from dependencies are downcased
joshspicer Jul 18, 2023
a39ea29
remove skipFeatureAutoMapping
joshspicer Jul 20, 2023
508e3c6
normalize feature ID earlier, and keep raw around
joshspicer Jul 20, 2023
4fe07b2
update test to add normalizedUserFeatureId
joshspicer Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ensure userFeatureIds resolved from dependencies are downcased
  • Loading branch information
@joshspicer
joshspicer authored Jul 18, 2023
commit 0fba6e0c3e7fd4e8dc61261a72d39f13384b871f
6 changes: 3 additions & 3 deletions src/spec-configuration/containerFeaturesOrder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ async function applyOverrideFeatureInstallOrder(

const tmpOverrideNode: FNode = {
type: 'override',
userFeatureId: overrideFeatureId,
userFeatureId: overrideFeatureId.toLowerCase(),
options: {},
roundPriority,
installsAfter: [],
Expand Down Expand Up @@ -424,7 +424,7 @@ async function _buildDependencyGraph(
for (const [userFeatureId, options] of Object.entries(dependsOn)) {
const dependency: FNode = {
type: 'resolved',
userFeatureId,
userFeatureId: userFeatureId.toLowerCase(),
options,
featureSet: undefined,
dependsOn: [],
Expand All @@ -440,7 +440,7 @@ async function _buildDependencyGraph(
for (const userFeatureId of installsAfter) {
const dependency: FNode = {
type: 'resolved',
userFeatureId,
userFeatureId: userFeatureId.toLowerCase(),
options: {},
featureSet: undefined,
dependsOn: [],
Expand Down