Skip to content

Conversation

FabioLuporini
Copy link
Contributor

fixes #1298

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #1421 into master will increase coverage by 10.83%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1421       +/-   ##
===========================================
+ Coverage   76.18%   87.02%   +10.83%     
===========================================
  Files         187      188        +1     
  Lines       27044    27070       +26     
  Branches     3672     3673        +1     
===========================================
+ Hits        20604    23557     +2953     
+ Misses       5975     3087     -2888     
+ Partials      465      426       -39     
Impacted Files Coverage Δ
devito/ir/clusters/algorithms.py 96.29% <62.50%> (-3.71%) ⬇️
devito/ir/equations/equation.py 87.76% <100.00%> (+0.64%) ⬆️
devito/ir/support/basic.py 92.12% <100.00%> (-0.02%) ⬇️
devito/ir/support/utils.py 93.68% <100.00%> (+0.06%) ⬆️
tests/test_dimension.py 100.00% <100.00%> (ø)
examples/misc/__init__.py 100.00% <0.00%> (ø)
devito/types/dimension.py 90.58% <0.00%> (+0.22%) ⬆️
devito/types/basic.py 94.76% <0.00%> (+0.34%) ⬆️
tests/test_dse.py 99.53% <0.00%> (+1.03%) ⬆️
tests/test_operator.py 97.75% <0.00%> (+1.12%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfabbf5...9859bed. Read the comment docs.

expr._dspace = dspace
expr._ispace = ispace
expr._conditionals = frozendict([(d, ()) for d in conditionals])
expr._conditionals = conditionals
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that the revert of yesterday? 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the isolated line yeah... but in practice no! these lines 😬

@mloubout mloubout merged commit caac6b8 into master Aug 5, 2020
@mloubout mloubout deleted the fix-issue-1298 branch August 5, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A function that appears in a ConditionalDimension, but not in the Operator input is not always being added to the parameters of the Operator.

2 participants