-
Notifications
You must be signed in to change notification settings - Fork 9
"Sub" snapshots. #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Sub" snapshots. #13
Conversation
Sorry if I caused conflicts, had to move some things around in main. If you haven't started on this yet then it's exactly the same, except |
@nedtwigg Hopefully I finally got it, please check my commit comments |
Looks perfect, that's the suffix bug I expected. No fun to be stuck in debugger, but good tour of the system. The next ones should be more fun, and then writing the inplace literal system should be really fun I think! Looks like it needs a spotlessApply to pass tests. Once CI is passing hit merge and start the next one. Re: UT_ selfie/selfie2 I'm on mobile today and can't view code easily, but if it passes CI it's good with me. |
Thanks I missed the spotless run. I will fix soon today |
d953044
to
1e7589b
Compare
- The issue was an extra offset while looking for suffix: `leaf` vs `/leaf` - The undertest-junit5/src/test/kotlin/undertest/junit5/UT_WithinMethodGCTest.kt got modified after test run. Probably want to revert the `selfie` `selfie2` change - It was a simple bug, but very hard to debug. Still I like how his selfie lib is working, pretty good stuff
1e7589b
to
07611c5
Compare
- so spotless doesn't complain about bad formatting
If you run this test you'll get this failure:
The assertion is expecting a snapshot file like this
but it's missing the
selfie/leaf=maple
part. If you open upUT_WithinMethodGC
, it will look like this:If you run that
UT_
test file (asunderTest
) then you'll see that the problem is repeatable. Stick a breakpoint on the lineand you should be able to walk through to the problem pretty well. I'll give a hint that the current cause is an off-by-one error when calculating a suffix. Maybe another problem pops up when that gets fixed, I dunno.