Skip to content

Feature/use native npm #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Jun 12, 2020
Merged

Feature/use native npm #606

Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
cf00d4d
poc: call native node-server from within java
simschla Jun 3, 2020
b07af27
resolve prettier config once only
simschla Jun 5, 2020
2180d35
extract http/url handling part into a pretty simple client...
simschla Jun 5, 2020
3c8d2ca
raw state: start node server and execute rest calls to it
simschla Jun 6, 2020
372107a
use native node approach for tsfmt
simschla Jun 7, 2020
51da6fe
remove dependency to j2v8
simschla Jun 7, 2020
9999bdd
spotlessApply
simschla Jun 7, 2020
03fbd98
add more details in case npm autodiscovery fails
simschla Jun 7, 2020
8f88dc2
remove j2v8 reference from readme
simschla Jun 7, 2020
589940c
cleanup server startup code
simschla Jun 7, 2020
48ce207
extract file handling to helper class
simschla Jun 7, 2020
3dcb1ec
refactor and use npmProcess helper instance
simschla Jun 7, 2020
78a0ea8
reduce log noise from npm install call
simschla Jun 7, 2020
bc3c86a
only listen on localhost
simschla Jun 7, 2020
57f97b9
cleanup logging
simschla Jun 7, 2020
d7f3564
enable spotless for js formatting
simschla Jun 7, 2020
ee2dd1d
format js files using spotless
simschla Jun 7, 2020
fbb3961
refactoring: extract inner classes and renamings
simschla Jun 7, 2020
eafb850
adapt changelog
simschla Jun 7, 2020
d47a949
adapt to newer copyright header
simschla Jun 7, 2020
674044b
try to fix circle-ci (use node for running internal spotlessJavascript)
simschla Jun 7, 2020
c70bc85
Remove javascript from our dogfooding.
nedtwigg Jun 8, 2020
12680c5
Fix spotbugs warning.
nedtwigg Jun 8, 2020
92197e1
Windows cache seems to be broken, we'll just let it be slow.
nedtwigg Jun 8, 2020
c0879e1
fixing ci build
simschla Jun 8, 2020
0d6bd65
fixing ci build
simschla Jun 9, 2020
7c91e93
Revert "fixing ci build"
simschla Jun 9, 2020
a3c5614
cleanup accidential sysout checkin
simschla Jun 9, 2020
42309c7
Make the windows build run the npmTest
nedtwigg Jun 11, 2020
f5e7e6c
Oops, windows build doesn't want './'
nedtwigg Jun 11, 2020
d319266
Oops, we need to store the test results too!
nedtwigg Jun 11, 2020
5764f4c
Add a test that recreates the problem I'm seeing.
nedtwigg Jun 11, 2020
a12343f
bump version numbers to latest
simschla Jun 10, 2020
2bc0464
improve robustness and error feedback
simschla Jun 11, 2020
6f8c550
adding a test to prove that we can support prettier-plugins now
simschla Jun 11, 2020
0808fc2
documenting the community-plugin benefit and adding more examples
simschla Jun 11, 2020
e2981e5
PR feedback: try to avoid `**/*.filetype` as target examples
simschla Jun 12, 2020
8eff924
PR feedback: add links to prettier plugins
simschla Jun 12, 2020
dd6f120
add support for prettier-plugins to maven-builds and document in README
simschla Jun 12, 2020
bc9410b
adapting test for new output format
simschla Jun 12, 2020
38053bc
and verify what we actually learned: error message needs to be relaye…
simschla Jun 12, 2020
08d8321
Update changes.
nedtwigg Jun 12, 2020
a69670e
Remove some empty newlines.
nedtwigg Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove j2v8 reference from readme
  • Loading branch information
@simschla
simschla committed Jun 7, 2020
commit 8f88dc20873df91b9fb865a44321196aad8c4a56
4 changes: 2 additions & 2 deletions plugin-gradle/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ spotless {
}
```

Spotless uses npm to install necessary packages locally. It runs tsfmt using [J2V8](https://github.com/eclipsesource/J2V8) internally after that.
Spotless uses npm to install necessary packages and run the `typescript-formatter` (`tsfmt`) package.

<a name="prettier"></a>

Expand Down Expand Up @@ -494,7 +494,7 @@ spotless {
}
```

Spotless uses npm to install necessary packages locally. It runs prettier using [J2V8](https://github.com/eclipsesource/J2V8) internally after that.
Spotless uses npm to install necessary packages and run the `prettier` (`tsfmt`) package.

<a name="eclipse-wtp"></a>

Expand Down