-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add support for Laravel 5.3 #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Laravel 5.3 is officially out. Would be great to have this PR merged as we want to craft a 5.3 app with Dingo. |
composer.json
Outdated
| "illuminate/filesystem": "5.1.* || 5.2.* || 5.3.*", | ||
| "illuminate/log": "5.1.* || 5.2.* || 5.3.*", | ||
| "illuminate/pagination": "5.1.* || 5.2.* || 5.3.*", | ||
| "laravel/lumen-framework": "5.1.* || 5.2.* || 5.3.*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lumen hasn't been updated to 5.3 yet.
|
Definitely something I'm interested in, but currently want to nail down the issue people are having in regards to 5.1, before adding another version to support. |
|
@hskrasek my company would need to upgrade to Laravel 5.3 within this 1 to 2 week because we need to start supporting |
|
I have upgraded to Laravel 5.3 Everything looks fine so far, except this PR need to include laravie/api@51f9c85 due to changes with Laravel Router. |
|
@Kaukov If you could make the change suggested by @crynobone, I'll give this a test soon and merge if we are all good. If you're busy though, I can make the change myself and merge in the PR from there. |
Lumen stable isn't 5.3 yet. Thanks @hskrasek
|
@hskrasek is it ok now? |
|
Hello guys, what should I do to get to work laravel 5.3 with Dingo? I'm getting this error message (gatherRouteMiddlewares..). Thank you. |
|
yebah! |
|
@hskrasek still require dingo/blueprint#43 to be merged in order to allow developer to install on L5.3 |
|
still not work I used php composer.phar require dingo/api:v1.0.*@dev Problem 1 |
|
@DesmondPang That is because I have not tagged a new beta yet. I'm probably going to soon, but if you want to try it out before than, switch to installing dev-master |
"require": {
"dingo/api": "dev-master"
},
"prefer-stable": true,
"minimum-stability": "dev" |
|
Thank you for your Beta 6 release. but I still got problem with dingo/blueprint. Need to release blueprint 0.2??? Problem 1 |
|
@DesmondPang Try it once more, looks like the composer file has been pointed to a tag pattern thats never existed. |
|
@hskrasek successful. Thank you so much. |
|
@hskrasek are you going to tag a new beta soon (in matter of days)? I have big refactoring on the table but I want to create tests first, but can't due to error :) Thank you. Btw. can I help you somehow? |
|
@jakubkratina |
|
@bkintanar: I can see that now, just updated the composer. Great work, thank you. Can I contribute to dingo development? |
|
@jakubkratina opensource is always open for contribution. 👍 |
|
I would like to, is here a contribution document? I have found only slack channel. Thank you. |
|
Plans for passport? #1159 |
No description provided.