Skip to content

Conversation

@Kaukov
Copy link
Contributor

@Kaukov Kaukov commented Aug 11, 2016

No description provided.

@Kaukov Kaukov mentioned this pull request Aug 11, 2016
@mochetts
Copy link

Laravel 5.3 is officially out. Would be great to have this PR merged as we want to craft a 5.3 app with Dingo.

composer.json Outdated
"illuminate/filesystem": "5.1.* || 5.2.* || 5.3.*",
"illuminate/log": "5.1.* || 5.2.* || 5.3.*",
"illuminate/pagination": "5.1.* || 5.2.* || 5.3.*",
"laravel/lumen-framework": "5.1.* || 5.2.* || 5.3.*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lumen hasn't been updated to 5.3 yet.

@hskrasek
Copy link
Member

Definitely something I'm interested in, but currently want to nail down the issue people are having in regards to 5.1, before adding another version to support.

@crynobone
Copy link
Contributor

@hskrasek my company would need to upgrade to Laravel 5.3 within this 1 to 2 week because we need to start supporting laravel/passport (which only support 5.3). I would very much like to NOT have to maintain a fork to handle this.

@crynobone
Copy link
Contributor

I have upgraded to Laravel 5.3

Everything looks fine so far, except this PR need to include laravie/api@51f9c85 due to changes with Laravel Router.

@hskrasek
Copy link
Member

@Kaukov If you could make the change suggested by @crynobone, I'll give this a test soon and merge if we are all good.

If you're busy though, I can make the change myself and merge in the PR from there.

Lumen stable isn't 5.3 yet. Thanks @hskrasek
@Kaukov
Copy link
Contributor Author

Kaukov commented Aug 25, 2016

@hskrasek is it ok now?

@jakubkratina
Copy link

Hello guys, what should I do to get to work laravel 5.3 with Dingo? I'm getting this error message (gatherRouteMiddlewares..). Thank you.

@hskrasek hskrasek merged commit 3bd1895 into dingo:master Aug 30, 2016
@bkintanar
Copy link

yebah!

@crynobone
Copy link
Contributor

@hskrasek still require dingo/blueprint#43 to be merged in order to allow developer to install on L5.3

@DesmondPang
Copy link

still not work

I used php composer.phar require dingo/api:v1.0.*@dev

Problem 1
- dingo/api v1.0.0-beta5 requires dingo/blueprint 0.2.* -> satisfiable by dingo/blueprint[0.2.x-dev] but these conflict with your requirements or minimum-stability.
- dingo/api v1.0.0-beta4 requires dingo/blueprint 0.2.* -> satisfiable by dingo/blueprint[0.2.x-dev] but these conflict with your requirements or minimum-stability.
- dingo/api 1.0.x-dev requires dingo/blueprint 0.2.* -> satisfiable by dingo/blueprint[0.2.x-dev] but these conflict with your requirements or minimum-stability.
- Conclusion: don't install dingo/api v1.0.0-beta3
- Installation request for phpdocumentor/reflection-docblock (locked at 3.1.0) -> satisfiable by phpdocumentor/reflection-docblock[3.1.0].
- Conclusion: remove laravel/framework v5.3.4
- Conclusion: don't install laravel/framework v5.3.4
- dingo/api v1.0.0-beta1 requires illuminate/routing 5.1.* -> satisfiable by illuminate/routing[v5.1.1, v5.1.13, v5.1.16, v5.1.2, v5.1.20, v5.1.22, v5.1.25, v5.1.28, v5.1.30, v5.1.31, v5.1.41, v5.1.6, v5.1.8].
- dingo/api v1.0.0-beta2 requires illuminate/routing 5.1.* -> satisfiable by illuminate/routing[v5.1.1, v5.1.13, v5.1.16, v5.1.2, v5.1.20, v5.1.22, v5.1.25, v5.1.28, v5.1.30, v5.1.31, v5.1.41, v5.1.6, v5.1.8].
- don't install illuminate/routing v5.1.1|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.13|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.16|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.2|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.20|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.22|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.25|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.28|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.30|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.31|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.41|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.6|don't install laravel/framework v5.3.4
- don't install illuminate/routing v5.1.8|don't install laravel/framework v5.3.4
- Installation request for laravel/framework (locked at v5.3.4, required as 5.3.) -> satisfiable by laravel/framework[v5.3.4].
- Installation request for dingo/api v1.0.
@dev -> satisfiable by dingo/api[1.0.x-dev, v1.0.0-beta1, v1.0.0-beta2, v1.0.0-beta3, v1.0.0-beta4, v1.0.0-beta5].

@hskrasek
Copy link
Member

@DesmondPang That is because I have not tagged a new beta yet. I'm probably going to soon, but if you want to try it out before than, switch to installing dev-master

@crynobone
Copy link
Contributor

crynobone commented Aug 30, 2016

"require": {
    "dingo/api": "dev-master"

},
"prefer-stable": true,
"minimum-stability": "dev"

@DesmondPang
Copy link

Thank you for your Beta 6 release. but I still got problem with dingo/blueprint. Need to release blueprint 0.2???

Problem 1
- Installation request for dingo/api v1.0.0-beta6 -> satisfiable by dingo/api[v1.0.0-beta6].
- dingo/api v1.0.0-beta6 requires dingo/blueprint 0.2.* -> satisfiable by dingo/blueprint[0.2.x-dev] but these conflict with your requirements or minimum-stability.

@hskrasek
Copy link
Member

@DesmondPang Try it once more, looks like the composer file has been pointed to a tag pattern thats never existed.

@DesmondPang
Copy link

@hskrasek successful. Thank you so much.

@jakubkratina
Copy link

@hskrasek are you going to tag a new beta soon (in matter of days)? I have big refactoring on the table but I want to create tests first, but can't due to error :) Thank you. Btw. can I help you somehow?

@bkintanar
Copy link

@jakubkratina v1.0.0-beta6 has been tagged an hour or so ago.

@jakubkratina
Copy link

@bkintanar: I can see that now, just updated the composer. Great work, thank you. Can I contribute to dingo development?

@bkintanar
Copy link

@jakubkratina opensource is always open for contribution. 👍

@jakubkratina
Copy link

I would like to, is here a contribution document? I have found only slack channel. Thank you.

@bkintanar
Copy link

here: https://github.com/dingo/api/blob/master/CONTRIBUTING.md

@pedroskakum
Copy link

Plans for passport? #1159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants