Add getMiddleware function to Route class #1537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getMiddleware function is missing and reported here: flipboxstudio/lumen-generator#25 Also I think you have to be able to query the middlewares. If the function is not necessary and you can query the middlewares with another method, please write it in the comments.
|
I noticed that this issue has not been released yet and I would like to submit a suggestion. Within the Laravel own Route class there is a method called gatherMiddleware that collects the middleware of the route. Shouldn't the method at least be called the same, since it is used in the same manner? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getMiddleware function is missing and reported here: flipboxstudio/lumen-generator#25
Also I think you have to be able to query the middlewares.
If the function is not necessary and you can query the middlewares with another method, please write it in the comments.