Chore/route caching #1629
Closed
Chore/route caching #1629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Error was caused by the eager loading functionality - Fix was to check for available includes if possible before blindly using them as an eager load
…route list command.
…link to the api boilerplate as option for new projects
fix `$version` data type of the `version()` support array.
This adds a `shouldReport` method as required by the updated contract. Currently it just always returns true - more sophisticated methods of determining if it should report could be implemented though. Fixes dingo#1624
…that implements the Laravel 5.8 contract - this should fix the main issues we’re seeing.
This creates a trait that contains logic needed to check the version of Laravel/lumen that is installed. Using said version it will provide the proper application stub for testing.
specialtactics
added a commit
to specialtactics/laravel-dingo-api
that referenced
this pull request
Mar 4, 2019
specialtactics
added a commit
that referenced
this pull request
Mar 4, 2019
Revert changes to not getting a fresh app based on feedback in PR #1629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert cache command based on feedback for PR #1618