Skip to content

Simplify / clean up Docker IP determination #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
matthiask opened this issue Feb 10, 2025 · 2 comments
Closed
2 tasks

Simplify / clean up Docker IP determination #2076

matthiask opened this issue Feb 10, 2025 · 2 comments
Assignees
@dr-rompecabezas
Labels
Djangonaut Space 🚀

Comments

@matthiask
Copy link
Member

As mentioned by @srus in #1854 (comment) we might be able to simplify the internal IP determination by using gateway.docker.internal

  • Test this in various more-or-less current docker and podman setups.
  • Pull request with docs and tests.
@matthiask matthiask assigned matthiask and unassigned matthiask Feb 10, 2025
@dr-rompecabezas
Copy link
Member

At first glance, this seems well documented and achievable. I'll give it a try.

@dr-rompecabezas dr-rompecabezas self-assigned this Feb 27, 2025
dr-rompecabezas added a commit to dr-rompecabezas/django-debug-toolbar that referenced this issue Mar 5, 2025
@dr-rompecabezas
Simplify Docker IP determination in middleware.py
4158db1 
- Updated `show_toolbar` function in `debug_toolbar/middleware.py` to
  use `gateway.docker.internal` for Docker IP determination.
- Updated `docs/changes.rst` to reflect the change.

django-commons#2076
@dr-rompecabezas dr-rompecabezas mentioned this issue Mar 5, 2025
Closed
3 tasks
@dr-rompecabezas
Copy link
Member

As discussed in a comment in the related PR, we are closing this issue as not planned.

@dr-rompecabezas dr-rompecabezas closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr-rompecabezas dr-rompecabezas

Labels
Djangonaut Space 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify Docker IP determination in middleware.py dr-rompecabezas/django-debug-toolbar
2 participants
@matthiask @dr-rompecabezas