socket timeout exception handler: TypeError: not enough arguments for format string

[mutang]

conn.optimize()
File "C:\tools\Python27\lib\site-packages\pysolr.py", line 825, in optimize
return self._update(msg, waitFlush=waitFlush, waitSearcher=waitSearcher)
File "C:\tools\Python27\lib\site-packages\pysolr.py", line 359, in _update
return self._send_request('post', path, message, {'Content-type': 'text/xml; charset=utf-8'})
File "C:\tools\Python27\lib\site-packages\pysolr.py", line 278, in _send_request
raise SolrError(error_message % [url, self.timeout])
TypeError: not enough arguments for format string

bug fix: pysolr.py line: 278 should change to:
patch here:
-raise SolrError(error_message % [url, self.timeout])
+raise SolrError(error_message % (url, self.timeout))

[acdha]

I believe this was fixed in 3.0.4:

74b0a36

Chris

On Friday, February 15, 2013 at 10:51 PM, mutang wrote:

conn.optimize()
File "C:\tools\Python27\lib\site-packages\pysolr.py", line 825, in optimize
return self._update(msg, waitFlush=waitFlush, waitSearcher=waitSearcher)
File "C:\tools\Python27\lib\site-packages\pysolr.py", line 359, in _update
return self._send_request('post', path, message, {'Content-type': 'text/xml; charset=utf-8'})
File "C:\tools\Python27\lib\site-packages\pysolr.py", line 278, in _send_request
raise SolrError(error_message % (url, self.timeout))
TypeError: not enough arguments for format string
bug fix: pysolr.py line: 278 should change to:
raise SolrError(error_message % (url, err))

—
Reply to this email directly or view it on GitHub (#70).

[mutang]

install infomation: pysolr-3.0.4-py2.7.egg-info, but in the pysolr.py file, thers are some codes:

author = 'Daniel Lindsley, Joseph Kocherhans, Jacob Kaplan-Moss'
all = ['Solr']
version = (3, 0, 1)

py file version does not match the distributed version

[mutang]

and I find you fix the previous line, but not fix the next line: raise SolrError(error_message % [url, self.timeout])

my python is 2.7.3, pysolr 3.0.4

74b0a36

[acdha]

That's actually intentional: the logging API allows arguments to be passed without forcing string interpolation so log formatters have more flexibility. The exception interface, by contrast, requires a single string.

Chris

On Saturday, February 16, 2013 at 12:46 AM, mutang wrote:

and I find you fix the previous line, but not fix the next line: raise SolrError(error_message % [url, self.timeout])
74b0a36 (74b0a36)

—
Reply to this email directly or view it on GitHub (#70 (comment)).

[mutang]

[acdha]

My apologies for attempting to answer your ticket from my phone. I'd forgotten that string interpolation does a strict type check for tuples.

I've updated & pushed out v3.0.5.
Chris

On Saturday, February 16, 2013 at 12:54 AM, mutang wrote:

—
Reply to this email directly or view it on GitHub (#70 (comment)).

[mutang]

It doesn't matter. thanks.