Extract decorative arrows in CSS #2063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! 💚 I've now merged #2050 and so there's a bunch of conflict in this one. Can you take a look? |
SaptakS
reviewed
May 6, 2025
| {{ form.body.as_field_group }} | ||
| </div> | ||
| {{ form.captcha }} | ||
| <p class="submit"> |
There was a problem hiding this comment.
I think changing to button and using content for the arrows make sense to me. Since we are changing it anyways, can we change this to <div> as well? I don't think a <p> tag (as we used to have before this PR) makes a lot of sense semantically here.
tut-tuuut
force-pushed
the
ahr/extract-decorative-arrows-in-css
branch
from
23a414c to
25a1de2
Compare
tut-tuuut
force-pushed
the
ahr/extract-decorative-arrows-in-css
branch
from
25a1de2 to
d2a6e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #2050, we use generated content in CSS for the decorative arrows in the contact form and the fundraising forms.
The last occurrence of
→appeared to be in a unused template (something related to the COC), I removed it. Less code, fewer problems. :]Screenshots in dark and bright mode:
Bright mode
Dark mode
aria-hidden="true"on decorative<hr>in the fundraising form.