Adding Kafka end_time support for batch processing and SASL optionality. #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VioletM
requested changes
Apr 9, 2025
| if start_from is not None: | ||
| ts_offsets = self._consumer.offsets_for_times(parts) | ||
| # get offsets for the timestamp ranges, if given | ||
| if start_from is not None and end_time is not None: |
There was a problem hiding this comment.
What if
(start_from is not None) and (end_time is None)
There was a problem hiding this comment.
Hmm this one I am not that sure, I dont think it really makes it more readable (it is a simple AND). I made a quick check on the folder as well, and I think it all without the parenthesis (in helpers.py for instance.
There was a problem hiding this comment.
oh, sorry, I wasn't clear. I meant what would happen in the case if start_from is specified and end_time is None?
It seems that this case is not covered
THis commit adds an end_time functionality to the kafka consumer function which makes it more batch-processing friendly, as it allows the user to achieve indempotency
lfagliano
force-pushed
the
vdb-kafka-end-time
branch
from
fef86c8 to
7985d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us what you do here
Short description
This PR enhances the Kafka source by adding an end_time parameter to the kafka_consumer function, allowing users to specify an upper time boundary for message consumption. This complements the existing start_from parameter, providing more precise control over the time range of messages to be consumed, allowing for batch processing to be idempotent.
Related Issues
Key changes:
Additional Context