Debian images: Use locale-gen instead of localdef #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of manually calling localdef caused any future update to the locales package to remove the manually installed locales, since locale-gen takes precendence. This would usually be encountered when a downstream Dockerfile added additional packages, and as a side effect caused an upgrade to the locales package. Fix by relying on the /etc/locale.gen file, which is the official place to specify which locales should be installed. Fixes docker-library#1112
tianon
reviewed
Dec 7, 2023
In case Debian changes the logic of how locale-gen works, this will flag it early during the build process.
lfittl
force-pushed
the
use-locale-gen
branch
from
f07e474 to
a42b684
Compare
Contributor
Author
Thanks for merging this! Happy to see this resolved :) |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 7, 2023
Changes: - docker-library/postgres@018d576: Merge pull request docker-library/postgres#1159 from lfittl/use-locale-gen - docker-library/postgres@a42b684: Debian packages: Add explicit check for locale-gen creating locales - docker-library/postgres@55e45ba: Debian images: Use locale-gen instead of localdef
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 8, 2023
Changes: - docker-library/postgres@ef9747f: Merge pull request docker-library/postgres#1160 from Earlopain/alpine3.19 - docker-library/postgres@25f6ba5: Add alpine 3.19 - docker-library/postgres@018d576: Merge pull request docker-library/postgres#1159 from lfittl/use-locale-gen - docker-library/postgres@a42b684: Debian packages: Add explicit check for locale-gen creating locales - docker-library/postgres@55e45ba: Debian images: Use locale-gen instead of localdef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of manually calling localdef caused any future update to the locales package to remove the manually installed locales, since locale-gen takes precendence. This would usually be encountered when a downstream Dockerfile added additional packages, and as a side effect caused an upgrade to the locales package.
Fix by relying on the /etc/locale.gen file, which is the official place to specify which locales should be installed.
Fixes #1112