Skip to content

Conversation

@regisbelson
Copy link
Contributor

Unless there's a way to only install the source headers from the postgres source, it's impossible to use this image as a base image for postgis because they are missing. It only adds 3 MB of data to the image to keep them:

REPOSITORY             TAG                 IMAGE ID            CREATED             SIZE
postgres               test                136c6c4d4782        10 minutes ago      35.3 MB
postgres               9.3-alpine          7c9bad9f1e8f        9 days ago          32.2 MB

@regisbelson regisbelson changed the title Keep libs so the image can be used as a base image for postgis Keep lib sources so the image can be used as a base image for postgis Jan 14, 2017
@yosifkit
Copy link
Member

Seems fine to me, though Dockerfile-alpine.template needs to be updated as well, otherwise the bot will revert this change when it runs.

@regisbelson
Copy link
Contributor Author

Cool ! I updated Dockerfile-alpine.template.

@yosifkit
Copy link
Member

Comparison of size difference:

$ # current:
postgres            9.6-alpine          c4d8fd02c94a        12 days ago         33.94 MB
$ # new
postgres            9.6-alpine          8a31e85fae3e        20 seconds ago      37.69 MB

@tianon
Copy link
Member

tianon commented Jan 25, 2017

Seems fair to me! 👍

@tianon tianon merged commit e430162 into docker-library:master Jan 25, 2017
@regisbelson regisbelson deleted the keep-libs branch January 26, 2017 15:50
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jan 27, 2017
- `bash`: 4.4.12
- `golang`: 1.7.5, 1.8rc3
- `mysql`: add automatic SSL support matching upstream behavior (docker-library/mysql#259)
- `openjdk`: debian 9~b154-1
- `php`: auto-create `APACHE_RUN_DIR` and `APACHE_LOCK_DIR` at runtime if necessary (docker-library/php#330)
- `postgres`: keep `include` for building against (docker-library/postgres#247)
- `rabbitmq`: add Alpine variant (docker-library/rabbitmq#137)
- `wordpress`: 4.7.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants