Skip to content

php7 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petemcfarlane opened this issue Dec 6, 2015 · 12 comments
Closed

php7 #106

petemcfarlane opened this issue Dec 6, 2015 · 12 comments

Comments

@petemcfarlane
Copy link

Is there any chance of moving the base image to php7 any time soon? It's now the stable version. Shall I submit a PR?

@tianon
Copy link
Member

tianon commented Dec 7, 2015 via email

@ahansson89
Copy link

What about making an environment variable where we can define the PHP version? -e PHP_VERSION=7.0 which defaults to the recommended one?

@petemcfarlane
Copy link
Author

Ok, thanks @tianon. Quoting from that post: "WordPress continues to encourage all users to run the latest and greatest versions of PHP, including PHP7 upon its release." But they do also mention they will have to support older versions too.

Making an environment variable seems like a viable option?

@tianon
Copy link
Member

tianon commented Dec 8, 2015 via email

@tianon
Copy link
Member

tianon commented Dec 8, 2015 via email

@tianon
Copy link
Member

tianon commented Dec 8, 2015 via email

@ahansson89
Copy link

docker run --name some-wordpress --link some-mysql:mysql -d wordpress:apache-php7

In this case there are going to be tons of different combinations which is probably not good either

@ahansson89
Copy link

I ended up creating a php7 image with apache for my own use. I published it on the Docker Registry for others to use. It is based on this image and I will do my best to keep it updated when new pull requests are being added to this repo. You can find the image here: https://hub.docker.com/r/ahansson89/wordpress-php7/

@lzhengqc
Copy link

lzhengqc commented Apr 4, 2016

ahansson89 I found your docker image https://hub.docker.com/r/ahansson89/wordpress-php7/ very useful. Is there a github location for the Dockerfile? Thanks.

@mbabker
Copy link

mbabker commented Jun 14, 2016

I can't say it's right or even well done, but for the Joomla image, I took the step of using different tags (similar to the Apache/FPM thing) for PHP 5.6 and PHP 7. joomla-docker/docker-joomla@9525cc2

@mlehner616
Copy link

Is there any way we can get the image from @ahansson89 pulled in? Does someone more familiar have time to do this? I'm not sure I have the time right now to do this. -Mike

@tianon
Copy link
Member

tianon commented Oct 6, 2016

There's some really great upstream discussion in https://core.trac.wordpress.org/ticket/36484, especially the following comment (https://core.trac.wordpress.org/ticket/36484#comment:10):

This is remembering that we're talking about the recommended PHP version. The recommended version should be providing an ideal experience for folks, we shouldn't be bumping to a bigger number just because it's there.

Given the PHP 5.6 support timeline, we'll be bumping it by WordPress 4.8 at the latest, so it'd be nice to use those intervening months to ensure the UX for the wider WordPress ecosystem under PHP 7 is solid.

I do think there's probably good cause to add multiple PHP versions here, however, likely similar to something like tomcat (which supports multiple versions of the JRE).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants