Update according to "Site Health" recommendations #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After running `wordpress:latest`, I got the following recommendations: 1. > We recommend that you update PHP Result: updated default PHP variant to 7.3, matching their recommended version. 2. > One or more recommended modules are missing Result: installed the missing `bcmath`, `exif`, and `imagick` modules, as recommended. Also, I've updated the `cli` images to match previous updates to the `alpine` images (and included these adjustments). I've verified that after building this and running from `php7.3/apache`, the only recommendations from "Site Health" are now the expected "You should remove inactive plugins", "You should remove inactive themes", and "Your site does not use HTTPS". After deleting the pre-included plugins and extra themes, I'm down to just the HTTPS warning (which is expected given that I'm running this as a one-off container and thus don't have HTTPS configured).
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
May 25, 2019
Changes: - docker-library/wordpress@1d53308: Merge pull request docker-library/wordpress#403 from infosiftr/site-health - docker-library/wordpress@9ee913e: Update according to "Site Health" recommendations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running
wordpress:latest, I got the following recommendations:Result: updated default PHP variant to 7.3, matching their recommended version.
Result: installed the missing
bcmath,exif, andimagickmodules, as recommended.Also, I've updated the
cliimages to match previous updates to thealpineimages (and included these adjustments).I've verified that after building this and running from
php7.3/apache, the only recommendations from "Site Health" are now the expected "You should remove inactive plugins", "You should remove inactive themes", and "Your site does not use HTTPS". After deleting the pre-included plugins and extra themes, I'm down to just the HTTPS warning (which is expected given that I'm running this as a one-off container and thus don't have HTTPS configured).Closes #402