Skip to content

Adjust the value of "error_reporting" to be the semantic equivalent of the suggested "4339" and add "E_PARSE" #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

tianon
Copy link
Member

@tianon tianon commented Aug 2, 2019

Closes #420

@tianon
Copy link
Member Author

tianon commented Aug 2, 2019

Looking through the list of excluded things in #420 (comment), I could understand the rationale from a WordPress perspective for the other exclusions, but agree that E_PARSE is a very curious omission (so I opted for the explicit list from upstream + E_PARSE rather than E_ALL & ~...).

Copy link
Member

@yosifkit yosifkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable default to me.

@yosifkit yosifkit merged commit 30f07e5 into docker-library:master Aug 2, 2019
@yosifkit yosifkit deleted the error_reporting branch August 2, 2019 23:47
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Aug 3, 2019
Changes:

- docker-library/wordpress@30f07e5: Merge pull request docker-library/wordpress#421 from infosiftr/error_reporting
- docker-library/wordpress@c9f1ca1: Adjust the value of "error_reporting" to be the semantic equivalent of the suggested "4339" and add "E_PARSE"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP parse errors not logged due to error_reporting value
2 participants