Convert app to use Compose file 2 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! The next Compose RC will refuse to run this because the volumes:
myvolume: |
|
@aanand thanks! how come that is required? |
bfirsh
force-pushed
the
compose-file-2
branch
2 times, most recently
from
0216a95 to
a51fd76
Compare
|
For one thing, mistyped volume names would otherwise result in the silent creation of a volume with the wrong name, which would lead to some pretty unpleasant behaviour in apps where named volumes are shared. |
| @@ -0,0 +1,36 @@ | |||
| version: 2 | |||
There was a problem hiding this comment.
This needs to be version: "2"
the version is a string
Signed-off-by: Ben Firshman <[email protected]>
The separate vote-apps directory was because networking didn't used to support aliases to remove the project name. Signed-off-by: Ben Firshman <[email protected]>
bfirsh
force-pushed
the
compose-file-2
branch
from
a51fd76 to
878cdeb
Compare
Signed-off-by: Dave Tucker <[email protected]>
bfirsh
added a commit
that referenced
this pull request
Feb 4, 2016
Convert app to use Compose file 2
Olivety
pushed a commit
to Olivety/example-voting-app
that referenced
this pull request
Nov 1, 2019
Add Server Schema & Skeletal Resolver
inikolchev
pushed a commit
to inikolchev/example-voting-app
that referenced
this pull request
Mar 14, 2022
tcscr
added a commit
to tcscr/example-voting-app
that referenced
this pull request
Dec 30, 2023
salaboy
added a commit
to marcosnils/example-voting-app
that referenced
this pull request
Feb 29, 2024
General updates and improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If looks good I will merge on release of Compose 1.6.
/cc @aanand @mgoelzer