Skip to content

update master #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Oct 10, 2017
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
3f5c3fb
docs(api): minor fix in cli
skipjack Sep 8, 2017
9cd50d5
docs(plugins): clarify and simplify `SourceMapDevToolPlugin` docs (#1…
skipjack Sep 8, 2017
a26cc70
docs(guides): update "external limitations" example in author-librari…
pfmmfp Sep 10, 2017
287e0e1
docs(plugins): update commons-chunk-plugin.md (#1560)
liorgreenb Sep 10, 2017
e8dc2f3
docs(guides): rewrite shimming (#1579)
skipjack Sep 12, 2017
2caa06a
docs(guides): fix small issues in shimming (#1591)
jeremenichelli Sep 13, 2017
ddaf684
docs(guides): fix entry path in typescript (#1592)
ltaloc Sep 13, 2017
28ac2fd
docs(guides): fix typos in production (#1584)
elliotwaite Sep 13, 2017
2ff84b9
fix(sponsors): update to reflect opencollective change (#1588)
sokra Sep 13, 2017
cb9a035
docs(config): update configuration-languages (#1590)
peterblazejewicz Sep 14, 2017
bee0f3e
docs(guides): update hot-module-replacement (#1539)
bdwain Sep 14, 2017
2af6968
docs(guides): update development.md (#1586)
marcusmolchany Sep 14, 2017
5f6a75e
docs(guides): update tree-shaking.md (#1589)
Sep 14, 2017
3dc7e74
docs(guides): update code-splitting (#1585)
diegofaria Sep 14, 2017
5003179
docs(plugins): update module-concatenation-plugin (#1565)
pspeter3 Sep 15, 2017
60f2679
docs(api): fix type in compiler.md (#1601)
Sep 18, 2017
eecdc8d
docs(config): update output.md (#1541)
metatoaster Sep 18, 2017
b3cd5ac
docs(api): add concurrent usage warning in node.md (#1599)
sokra Sep 18, 2017
cdf2c87
docs(guides): update environment-variables (#1549)
grisanu Sep 18, 2017
9cfbbe7
Merge remote-tracking branch 'upstream/master'
hello-lizhihua Sep 19, 2017
51a9aad
Swap ordering of pre/post loaders (#1602)
DrewML Sep 21, 2017
2af9244
docs(sponsors): update segment's donations (#1603)
sokra Sep 22, 2017
7f47223
Merge remote-tracking branch 'upstream/master'
hello-lizhihua Sep 24, 2017
25a3d6d
Merge branch 'master' into cn
hello-lizhihua Oct 10, 2017
debfddd
Merge remote-tracking branch 'upstream/cn' into cn
hello-lizhihua Oct 10, 2017
57fb4d4
update contributors
hello-lizhihua Oct 10, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs(guides): update code-splitting (#1585)
Suggest solutions to the problem right away seems to be a 
better approach. Use similar text as was used here:

https://webpack.js.org/api/module-methods/#import-
  • Loading branch information
diegofaria authored and skipjack committed Sep 14, 2017
commit 3dc7e7403ecb8e9a3987fc57d9ce02499514b9fb
2 changes: 1 addition & 1 deletion src/content/guides/code-splitting.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ T> The [`CommonsChunkPlugin`](/plugins/commons-chunk-plugin) is also used to spl

Two similar techniques are supported by webpack when it comes to dynamic code splitting. The first and more preferable approach is use to the [`import()` syntax](/api/module-methods#import-) that conforms to the [ECMAScript proposal](https://github.com/tc39/proposal-dynamic-import) for dynamic imports. The legacy, webpack-specific approach is to use [`require.ensure`](/api/module-methods#require-ensure). Let's try using the first of these two approaches...

W> `import()` calls use [promises](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise). If you want to support older browsers that lack `Promise` support (e.g. Internet Explorer), you'll need to include a `Promise` polyfill _before_ your primary bundles.
W> `import()` calls use [promises](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise) internally. If you use `import()` with older browsers, remember to shim `Promise` using a polyfill such as [es6-promise](https://github.com/stefanpenner/es6-promise) or [promise-polyfill](https://github.com/taylorhakes/promise-polyfill).

Before we start, let's remove the extra [`entry`](/concepts/entry-points/) and [`CommonsChunkPlugin`](/plugins/commons-chunk-plugin) from our config as they won't be needed for this next demonstration:

Expand Down