Error in generated Entity Proxy class

[compains]

I have started to get errors after updating deployed aplication.

Parse error: syntax error, unexpected '?', expecting variable (T_VARIABLE) on /app/cache/prod/doctrine/orm/Proxies/__CG__AppBundleEntityEntityName.php

Original method

someMethod( ClassName $inputParam)
generated proxy

someMethod ( ? \Full\NamespacePath\ClassName $inputParam)
I just deleted the ? in the generated code and is working again.

Just to be sure, I re-deployed the app and I got the same issue.

Its running on Php 7.0.8. Deployed version of doctrine common is 2.7.0 (actually this started to happen after update from 2.6.1 to 2.7.0 doctrine/dbal from 2.5.5 to 2.4.5 (don't know why composer has downgraded this package)

[Majkl578]

Could not reproduce, can you provide exact code that breaks?

You can modify this snippet (just run composer require doctrine/common before executing it):

<?php

require __DIR__ . '/vendor/autoload.php';

class TestClass {
    public function someMethod(DateTime $inputParam) {}
}

$generator = new Doctrine\Common\Proxy\ProxyGenerator(__DIR__, 'Proxy');
$metadata = new class implements Doctrine\Common\Persistence\Mapping\ClassMetadata {
    public function getName() { return TestClass::class; }
    public function getIdentifier() {}
    public function getReflectionClass() { return new ReflectionClass(TestClass::class); }
    public function isIdentifier($fieldName) {}
    public function hasField($fieldName) {}
    public function hasAssociation($fieldName) {}
    public function isSingleValuedAssociation($fieldName) {}
    public function isCollectionValuedAssociation($fieldName) {}
    public function getFieldNames() {}
    public function getIdentifierFieldNames() {}
    public function getAssociationNames() {}
    public function getTypeOfField($fieldName) {}
    public function getAssociationTargetClass($assocName) {}
    public function isAssociationInverseSide($assocName) {}
    public function getAssociationMappedByTargetField($assocName) {}
    public function getIdentifierValues($object) {}
};

$generator->generateProxyClass($metadata, 'TestClass-proxy.php');

require __DIR__ . '/TestClass-proxy.php';
$proxy = new Proxy\__CG__\TestClass;
var_dump($proxy instanceof TestClass); // true
var_dump(PHP_VERSION); // 7.0.11

[compains]

Not sure where to put this snippet and how to run it. Any tip? please

[Majkl578]

Just:

1. create a new folder;
2. create a file, e.g. test.php, with this snippet inside;
3. then run composer require doctrine/common;
4. and then php test.php.

It will create a proxy class for a method with the same signature you mentioned in the bug report, but it should create a proxy without any parse errors.
If you can modify the code to produce a broken proxy class, that would help.
Works for me under 7.0.11, 7.0.13, 7.1.0 RC6 and 7.1.0 GA.

[compains]

I managed to reproduce using this script.

<?php 
require __DIR__ . '/vendor/autoload.php';


class Servicio
{
}

class TestClass {
/**
     * @param Servicio $servicio
     * @param \DateTime $dateTime
     * @return mixed
     */
    public function getTasaAmpliada(Servicio $servicio = null, \DateTime $dateTime)
    {
    }
}

$generator = new Doctrine\Common\Proxy\ProxyGenerator(__DIR__, 'Proxy');
$metadata = new class implements Doctrine\Common\Persistence\Mapping\ClassMetadata {
    public function getName() { return TestClass::class; }
    public function getIdentifier() {}
    public function getReflectionClass() { return new ReflectionClass(TestClass::class); }
    public function isIdentifier($fieldName) {}
    public function hasField($fieldName) {}
    public function hasAssociation($fieldName) {}
    public function isSingleValuedAssociation($fieldName) {}
    public function isCollectionValuedAssociation($fieldName) {}
    public function getFieldNames() {}
    public function getIdentifierFieldNames() {}
    public function getAssociationNames() {}
    public function getTypeOfField($fieldName) {}
    public function getAssociationTargetClass($assocName) {}
    public function isAssociationInverseSide($assocName) {}
    public function getAssociationMappedByTargetField($assocName) {}
    public function getIdentifierValues($object) {}
};

$generator->generateProxyClass($metadata, 'TestClass-proxy.php');

require __DIR__ . '/TestClass-proxy.php';
$proxy = new Proxy\__CG__\TestClass;
var_dump($proxy instanceof TestClass);

when i run

php test.php

I get the same error:

PHP Parse error: syntax error, unexpected '?', expecting variable (T_VARIABLE) in /home/ubuntu/test/TestClass-proxy.php on line 179

And the generated file has this method

public function getTasaAmpliada(?\Servicio $servicio = NULL, \DateTime $dateTime)
    {
        $this->__initializer__ && $this->__initializer__->__invoke($this, 'getTasaAmpliada', [$servicio, $dateTime]);
        return parent::getTasaAmpliada($servicio, $dateTime);
    }

[Ocramius]

Argh, we didn't consider this scenario. The first parameter is nullable, but not optional (due to second parameter). This is a fuckup on both sides, since the code is bogous, yet valid.

…

On 2 Dec 2016 8:10 a.m., "compains" ***@***.***> wrote: I managed to reproduce using this script. `<?Php require *DIR* . '/vendor/autoload.php'; class Servicio { } class TestClass { /** * @param <https://github.com/param> Servicio $servicio * @param <https://github.com/param> \DateTime $dateTime * @return <https://github.com/return> mixed */ public function getTasaAmpliada(Servicio $servicio = null, \DateTime $dateTime) { } } $generator = new Doctrine\Common\Proxy\ProxyGenerator(*DIR*, 'Proxy'); $metadata = new class implements Doctrine\Common\Persistence\Mapping\ClassMetadata { public function getName() { return TestClass::class; } public function getIdentifier() {} public function getReflectionClass() { return new ReflectionClass(TestClass::class); } public function isIdentifier($fieldName) {} public function hasField($fieldName) {} public function hasAssociation($fieldName) {} public function isSingleValuedAssociation($fieldName) {} public function isCollectionValuedAssociation($fieldName) {} public function getFieldNames() {} public function getIdentifierFieldNames() {} public function getAssociationNames() {} public function getTypeOfField($fieldName) {} public function getAssociationTargetClass($assocName) {} public function isAssociationInverseSide($assocName) {} public function getAssociationMappedByTargetField($assocName) {} public function getIdentifierValues($object) {} }; $generator->generateProxyClass($metadata, 'TestClass-proxy.php'); require *DIR* . '/TestClass-proxy.php'; $proxy = new Proxy_*CG*_\TestClass; var_dump($proxy instanceof TestClass); ` when i run php test.php I get the same error: PHP Parse error: syntax error, unexpected '?', expecting variable (T_VARIABLE) in /home/ubuntu/test/TestClass-proxy.php on line 179 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#751 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakOCcYk8-6n4oPxA-HTZkYg0xUxFlks5rD9KAgaJpZM4LBKLG> .

[compains]

This means that a signature like

public function getTasaAmpliada(Servicio $servicio = null, \DateTime $dateTime=null)

should work?

[compains]

Changing signature works.

This is considered a bug and will be fixed or I should take care of doing proper function signatures?

[Ocramius]

@compains this is a valid bug, and needs fixing.

[Majkl578]

Changing isOptional() to isDefaultValueAvailable() inside ProxyGenerator::formatType() should do the trick I believe. @Ocramius should I send a PR or are working it already? :)

---

And it doesn't even generate a warning... 😢

[Ocramius]

@Majkl578 I'm currently working on a patch: should take few minutes.