Improve FileDriver mapping data retrieval by caching results locally #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where mapping Data is not cached by calling ```initilaize();``` It makes sense to cache results after parsing the Yaml file.
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DCOM-368 We use Jira to track the state of pull requests and the versions they got |
|
@gries do you think that you can test the change? Needs a test subclassing the file driver |
|
I have added a test that calls the |
|
any update on this? |
Ocramius
added a commit
that referenced
this pull request
Dec 25, 2015
Improve MappingData retrieval by caching Results.
|
@gries merged and ready for 2.7.0, thanks! |
Ocramius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where mapping Data is not cached by calling
initilaize();It makes sense to cache results after parsing the Yaml file.