Skip to content

Removed empty /lib/vendor directory from auto-generated ZIP archives #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Removed empty /lib/vendor directory from auto-generated ZIP archives #718

merged 1 commit into from
Jul 22, 2017

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented May 19, 2016

In the downloaded ZIP archive there's an empty /lib/vendor directory... let's remove it

In the downloaded ZIP archive there's an empty/lib/vendor directory... let's remove it
@stof
Copy link
Member

stof commented May 19, 2016

@beberlei @Ocramius is this submodule actually still useful ?

@Ocramius
Copy link
Member

@beberlei @Ocramius is this submodule actually still useful ?

It is not - should just be dropped. Doing that ASAP.

@Ocramius Ocramius added this to the 2.7.3 milestone Jul 22, 2017
@Ocramius Ocramius self-assigned this Jul 22, 2017
@Ocramius Ocramius merged commit 73ae8ff into doctrine:master Jul 22, 2017
@Ocramius
Copy link
Member

@stof removed in 4167060

@Ocramius Ocramius modified the milestones: 2.8.0, 2.7.3 Jul 22, 2017
@Ocramius Ocramius changed the title Remove empty /lib/vendor directory from auto-generated ZIP archives Removed empty /lib/vendor directory from auto-generated ZIP archives Jul 22, 2017
Majkl578 pushed a commit to Majkl578/doctrine-persistence that referenced this pull request Jun 9, 2018
jwage pushed a commit to doctrine/reflection that referenced this pull request Jun 13, 2018
@mlocati mlocati deleted the patch-1 branch December 27, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants