Skip to content

small improvements from humbug #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 18, 2016
Merged

Conversation

BreiteSeite
Copy link
Contributor

Hi,

i tried humbug for the first time (against your codebase) and wanted to share some slight modifications i made to fix 2 "escapes".

I would take no offence if you didn't want to merge such a small change.

@@ -8,3 +8,4 @@ vendor/
composer.lock
doctrine-common-*.tar
doctrine-common-*.tar.gz
humbuglog.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have an ignored reports folder for tool reports. Please put the file in it instead of ignoring a new root file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i will update accordingly.

"logs": {
"text": "reports/humbuglog.txt"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF EOL still needed

@Ocramius Ocramius self-assigned this Jun 18, 2016
@Ocramius Ocramius added this to the 2.7.0 milestone Jun 18, 2016
@Ocramius Ocramius merged commit f504d25 into doctrine:master Jun 18, 2016
@Ocramius
Copy link
Member

@BreiteSeite thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants