-
-
Notifications
You must be signed in to change notification settings - Fork 291
small improvements from humbug #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ass name with classname of the SUT
@@ -8,3 +8,4 @@ vendor/ | |||
composer.lock | |||
doctrine-common-*.tar | |||
doctrine-common-*.tar.gz | |||
humbuglog.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have an ignored reports
folder for tool reports. Please put the file in it instead of ignoring a new root file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, i will update accordingly.
"logs": { | ||
"text": "reports/humbuglog.txt" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOF EOL still needed
@BreiteSeite thanks! |
Hi,
i tried humbug for the first time (against your codebase) and wanted to share some slight modifications i made to fix 2 "escapes".
I would take no offence if you didn't want to merge such a small change.