ProxyGenerator: Disallow creating proxies for abstract and final classes #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Feb 4, 2017
| @@ -260,6 +260,8 @@ public function setProxyClassTemplate($proxyClassTemplate) | |||
| */ | |||
| public function generateProxyClass(ClassMetadata $class, $fileName = false) | |||
| { | |||
| $this->verifyClassValidnessForProxy($class); | |||
There was a problem hiding this comment.
I admit I was out of fantasy. 😇 Renamed.
| @@ -306,6 +308,17 @@ public function generateProxyClass(ClassMetadata $class, $fileName = false) | |||
| rename($tmpFileName, $fileName); | |||
| } | |||
|
|
|||
| private function verifyClassValidnessForProxy(ClassMetadata $class) | |||
There was a problem hiding this comment.
Please add relevant @throws annotations in the private/public API of the class being affected by the change
Majkl578
force-pushed
the
proxy-disallow-abstact-final
branch
from
dc27414 to
c116421
Compare
Ocramius
approved these changes
Feb 4, 2017
|
@Majkl578 awesome, thanks! |
This was referenced Feb 4, 2017
|
👌 |
|
Unfortunately, this breaks Sylius (already fixed in dev-master) - looks like we don't really use an entity which was final, so it has started to break after an update to 2.8. If anyone bumped onto this issue as well, after using this workaround https://github.com/Sylius/SyliusElasticSearchPlugin/pull/55/files#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780R41 it works just fine :) |
|
Yes, this breaks using https://github.com/moneyphp/money/ as an embeddable. |
|
Related: doctrine/orm#6625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #770
Related to symfony/symfony#21509
This could theoretically be a BC break, but I can't imagine any such scenario.