-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Typo in json config prevented me from running my app on Linux #12924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hum 🤔 ... that's interesting because we doc "keys" as case-insensitive ...
However, yes on the specific point. Let's match anyway. @HaoK Does |
|
With a capital P i get this error: |
|
hum ... interesting ... yeah, that's not what one would expect from the case change. @HaoK will 👀 that. He may direct u to open an engineering issue. Stand-by for his reaction. After he looks, we'll merge this anyway. It is better to match, of course, so we thank u for sending the PR. |
|
This is an issue with Kestrel since its doing its own configuration binding/reading/parsing, cc @Tratcher |
|
But configuration.GetSection shouldn't be case sensitive, so it must be something else that is causing the case issue |
|
That's what I was thinking. I feel an engineering investigation might ensue. Should @armitagemderivitec open an issue in engineering and we can just proceed to merge this for docs? |
|
Yeah that's best, open an issue with the repro config and we can take a look |
|
@armitagemderivitec Open an issue at ... https://github.com/aspnet/AspNetCore/issues ... and describe that. Include the stack trace. I'll go ahead with this. We want to match the casing no matter the underlying casing issue. |
Endpoints should have a lower case 'p' as per:
https://github.com/aspnet/AspNetCore/blob/c288baf967ddb615162e71ad924bd14526194908/src/Servers/Kestrel/Core/src/Internal/ConfigurationReader.cs#L16