Skip to content

Update the readme for RC2. #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2016
Merged

Update the readme for RC2. #1436

merged 2 commits into from
May 16, 2016

Conversation

glennc
Copy link
Contributor

@glennc glennc commented May 13, 2016

Can I get some reviews? @danroth27 @Eilon @shanselman

What feed should we actually ask people to use here?

@dnfclas
Copy link

dnfclas commented May 13, 2016

Hi @glennc, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

<configuration>
<packageSources>
<clear />
<add key="AspNetCI" value="https://www.myget.org/F/aspnetcirelease/api/v3/index.json" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouoldn't this be aspnetrelease and not aspnetcirelease? My understanding is that aspnetcirelease contains untested packages...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or aspnetrc2 which has specifially the rc2 escrow packages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend aspnetrelease... aspnetrc2 can potentially go away.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, no, none of the above. Use aspnetvnext only. The aspnetrelease feed will be cleared out very soon once we release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this is talking about nightly builds - I don't think we will keep updating aspnetrc2 feed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change to aspnetvnext.

@Eilon
Copy link
Contributor

Eilon commented May 16, 2016

:shipit:

@glennc glennc merged commit d2ac795 into dev May 16, 2016
ryanbrandenburg pushed a commit that referenced this pull request Nov 22, 2018
Fix comment, it's setting sign in scheme (old left-over from copy-paste?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants