Skip to content

Remove old artifacts from Home repo #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Remove old artifacts from Home repo #1754

merged 1 commit into from
Sep 13, 2016

Conversation

danroth27
Copy link
Member

It's time to do some spring cleaning on the Home repo and remove all the old files that are no longer relevant.

@pranavkm @glennc @muratg @Eilon Please review.

@dnfclas
Copy link

dnfclas commented Sep 13, 2016

Hi @danroth27, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@pranavkm
Copy link
Contributor

:shipit:

@danroth27 danroth27 merged commit 3b8fc8c into dev Sep 13, 2016
@Zazcallabah
Copy link

This commit just broke all our vsts builds.

https://blogs.msdn.microsoft.com/uk_faculty_connection/2015/09/07/continuous-integration-and-testing-using-visual-studio-online/ still references code in this repo. I seem to remember the official guide doing the same, but it seems to be updated now.

What is the currently preferred way of getting a rc1 project to build in vsts ci?

@danroth27
Copy link
Member Author

@Zazcallabah You are welcome to sync to a particular commit or tag in the Home repo, but RC1 and RC2 are no longer supported now that 1.0.0 is out and available.

@Zazcallabah
Copy link

That wouldn't help in this case, would it? Since dnvminstall.ps1 itself does web requests to other files in this repo.

@danroth27
Copy link
Member Author

@Zazcallabah Correct, you would have to create a modified version of dnvminstall.ps1. Can you update to RTM?

@eriksendc
Copy link

Hi @danroth27

My business, @Zazcallabah , is suffering terribly with this having happened. I totally get that things aren't supported, but tearing down what had been allowing VSTS builds to work without an announcement has really hurt us. For a thousand business-related reasons we're having to stick with RC1 for a few more weeks.

How do we move forward from here? I was never an expert on the powershell scripts that had previously been a part of this build solution. Can we have some guidance and access to what we'll need to rebuild our own version of this stuff? Since it's gone I don't know where to go looking for it. But isn't there a way to just put a few things back just for another few weeks and then we can plan, calmly and coolly to get our own build script working?

Many thanks in advance for your consideration.

Regards,
Brian Eriksen

@MaximRouiller
Copy link

MaximRouiller commented Sep 20, 2016

If you can, fork https://github.com/aspnet/Home/tree/v1.0.0-rc1-final and change the Urls inside to match to your own fork.

I haven't tested it but it should work. The important part is replacing those aspnet/home/dev by the right repository.

@danroth27 would that work?

danroth27 added a commit that referenced this pull request Sep 20, 2016
@danroth27
Copy link
Member Author

danroth27 commented Sep 20, 2016

OK, to give folks a bit more time to deal with this change I have temporarily added back the dnvm scripts: #1761

I've also posted an announcement to let folks know that we will remove the dnvm scripts on Oct 31, 2016: aspnet/Announcements#205.

Please ensure that your infrastructure has been updated by that date to no longer depend on dnvm from the https://github.com/aspnet/Home repo. We strongly recommend updating to the latest supported release to ensure your applications are running on stable and secure bits.

@danroth27
Copy link
Member Author

@MaximRouiller Yes, forking and updating the scripts would technically work, but you would be better off doing a full update to the latest stable and supported release.

@eriksendc
Copy link

eriksendc commented Sep 20, 2016

Hi @danroth27 , First thanks so much for giving us time to regroup. Now that this is out there as a deadline to hit, I'll be sure our team is ready for things to disappear on 31 October. That's really super helpful.

I had reported #1757 a few days ago and got pointed to this issue by @MaximRouiller . I've just retried a build and I'm still having the main issue I reported in #1757. The powershell script we took from a Microsoft post (now torn down) is in #1757 for reference. The issue is that https://raw.githubusercontent.com/aspnet/Home/dev/dnvminstall.ps1 is still not present. Who would be the right person to resurrect https://raw.githubusercontent.com/aspnet/Home/dev/dnvminstall.ps1?

Thanks,
Brian Eriksen

danroth27 added a commit that referenced this pull request Sep 20, 2016
* Revert "Remove old artifacts from Home repo (#1754)"

This reverts commit 3b8fc8c.

* Add back dnvm scripts
@danroth27
Copy link
Member Author

danroth27 commented Sep 20, 2016

@eriksendc I just merged the PR (#1761) so dnvminstall.ps1 is now (temporarily) back in the Home repo where it was.

@eriksendc
Copy link

@danroth27 I just tried again and we're back in business! I cannot thank you enough for your consideration and willingness to put stuff back in place for us so that we can march towards a known deadline. We never really wanted to be where we are with still being on RC1. But we're trying to get out the door with our new business. Not that that's your issue! :) If you're interested, though, you're helping us help pets. Check out getyourpet.com.

Thanks again!
Brian Eriksen

@danroth27
Copy link
Member Author

danroth27 commented Sep 20, 2016

If you're interested, though, you're helping us help pets. Check out getyourpet.com.

@shanselman @jongalloway ASP.NET Core is saving kittens!! 😸

@eriksendc
Copy link

Hi @danroth27 ,

As of 6pm EDT last night we're officially saving puppies and kittens at https://getyourpet.com/ and your giving us a reprieve on the ability to continue to build our RC1-based app on Visual Studio Team Services was really important in keeping us on track. Thank you again!

When we last interacted on this you set a [very reasonable] deadline of 31 Oct for pulling down the assets that are supporting RC1 builds. Our plan had been to release on 15 Oct and then spend 15-31 Oct porting to .NET Core 1.0 RTM. We slipped and now we're just getting to the port. We are 100% committed to getting to .NET Core 1.0 RTM immediately. In fact we've already started. But it may take us a week to do the work and a week to test and deploy. Is there any way you would consider changing the date to 15 Nov so, while we're porting, if we need to do an emergency patch to production then we can still do builds through Visual Studio Team Services?

I understand completely if you need to stick to 31 Oct. If there's some specific thing that this request will hold up, I totally understand. But if you do have flexibility, please consider this 2-week extension.

By the way, many thanks to you and everyone Microsoft for this whole new world we're now coding in. .NET Core is just such an amazing thing. It's just so lightening fast and rock-solid stable!

And thanks @shanselman and @jongalloway for answering my questions at the community stand up along the way. I haven't been able to watch for the past month or two as I've been working 16-hour days on getting Get Your Pet to market. I'm looking forward to binge watching to catch up, though!

Hope y'all are having a nice Sunday!

Regards,
Brian Eriksen

@danroth27
Copy link
Member Author

danroth27 commented Oct 31, 2016

For puppies and kittens I think we can do that 😺. I've updated the corresponding announcement issue: aspnet/Announcements#205.

@eriksendc
Copy link

@danroth27 Thanks again, Dan! And we're already making great progress in migrating to .NET Core 1.0 RTM. I promise to not bother you with any more requests like this.

@danroth27
Copy link
Member Author

@eriksendc Are you guys ok for us to remove the dnvm stuff at this point?

@eriksendc
Copy link

Hi @danroth27 Yes we got onto RTM so we're all set. And we saw quite a performance improvement after we put out the RTM release. Thanks again for giving us the extension on this.

Regards and Happy Holidays,
Brian Eriksen

@danroth27
Copy link
Member Author

Yes we got onto RTM so we're all set. And we saw quite a performance improvement after we put out the RTM release

Nice! Happy to hear that! 😄

@natemcmaster natemcmaster deleted the danroth27/homecleanup branch July 6, 2018 19:36
ryanbrandenburg pushed a commit that referenced this pull request Nov 27, 2018
Message writing optimization (#1683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants