-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[automated] Merge branch 'release/5.0' => 'master' #28523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automated] Merge branch 'release/5.0' => 'master' #28523
Conversation
* Upload ProductVersion.txt to blob feed * Only upload file during Winx64/x86 build * Deduplicate prop name
* Increase height for longer strings * Update thm.xml * Move fix to Hosting Bundle * Fixup * Fixup * fixup * Temporarily upload installers * Fix height
* Make sure SharedFx & TargetingPack msi names match * Insert packageVersion into OutputName when available * Move props around again
cddaf8b
to
f17c23b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving branch merge.
Hello @msftbot[bot]! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…t specify ToolExe (dotnet#28416) The RazorTagHelper task in the SDK is invoked by targets outside the SDK. Consequently, any new requirements on the tasks need to be compatible with these versions. In 5.0, we changed the task to expect the path to be passed in by the ToolExe property. This changes allows using dotnet.exe from the ambient PATH to be used instead (the previous behavior)
@wtgodbe I'm assuming you know something about the targeting pack :) |
Looking |
I detected changes in the release/5.0 branch which have not been merged yet to master. I'm a robot and am configured to help you automatically keep master up to date, so I've opened this PR.
This PR merges commits made on release/5.0 by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/5.0-to-master'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
or if you are using SSH
Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.