Enable IDE0005 analyzer in the build

.globalconfig

@@ -10,9 +10,6 @@ dotnet_diagnostic.CA1304.severity = error
 # CA1310: Specify StringComparison for correctness
 dotnet_diagnostic.CA1310.severity = error
 
-# TODO: remove this - https://github.com/dotnet/aspnetcore/issues/47912
-dotnet_diagnostic.EnableGenerateDocumentationFile.severity = none
-
 # Referencing types that are defined in M.CA.Workspaces is not appropriate
 # for analyzers or source generators that might be invoked from a command
 # line build because editor-specific types in M.CA.Workspaces are not
@@ -29,3 +26,4 @@ dotnet_diagnostic.EnableGenerateDocumentationFile.severity = none
 # to see if they are from a Workspaces assembly so it will take longer than the
 # greedier (and stricter) check for references overall.
 roslyn_correctness.assembly_reference_validation = relaxed
+

Directory.Build.targets

@@ -46,6 +46,18 @@
     <SuppressDependenciesWhenPacking Condition="'$(SuppressDependenciesWhenPacking)' == '' AND '$(IsAnalyzersProject)' == 'true'">true</SuppressDependenciesWhenPacking>
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!--
+      Make sure any documentation comments which are included in code get checked for syntax during the build, but do
+      not report warnings for missing comments.
+      CS1573: Parameter 'parameter' has no matching param tag in the XML comment for 'parameter' (but other parameters do)
+      CS1591: Missing XML comment for publicly visible type or member 'Type_or_Member'
+      CS1712: Type parameter 'type_parameter' has no matching typeparam tag in the XML comment on 'type_or_member' (but other type parameters do)
+    -->
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <NoWarn Condition=" '$(IsShipping)' != 'true'">$(NoWarn);CS1573;CS1591;CS1712</NoWarn>
+  </PropertyGroup>
+
   <PropertyGroup Condition=" '$(MSBuildProjectExtension)' == '.csproj' ">
     <PackageId Condition=" '$(PackageId)' == '' ">$(AssemblyName)</PackageId>
     <IsPackable

src/Analyzers/Analyzers/src/Microsoft.AspNetCore.Analyzers.csproj

@@ -2,17 +2,14 @@
   <PropertyGroup>
     <Description>CSharp Analyzers for ASP.NET Core.</Description>
     <PackageTags>aspnetcore</PackageTags>
-
     <!--
       This package is for internal use only. It contains analyzers that are bundled in the .NET Core Web SDK.
 
       We do need to pack it so it can be picked up by the Web SDK.
     -->
     <IsShippingPackage>false</IsShippingPackage>
-
     <TargetFramework>netstandard2.0</TargetFramework>
     <IncludeBuildOutput>false</IncludeBuildOutput>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <NuspecFile>$(MSBuildProjectName).nuspec</NuspecFile>
     <Nullable>Enable</Nullable>
   </PropertyGroup>

src/Components/Analyzers/src/Microsoft.AspNetCore.Components.Analyzers.csproj

@@ -4,7 +4,6 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <IncludeBuildOutput>false</IncludeBuildOutput>
     <NoPackageAnalysis>true</NoPackageAnalysis>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <Description>Roslyn analyzers for ASP.NET Core Components.</Description>
   </PropertyGroup>
 

src/FileProviders/Manifest.MSBuildTask/src/Microsoft.Extensions.FileProviders.Embedded.Manifest.Task.csproj

@@ -4,7 +4,6 @@
     <Description>MSBuild task to generate a manifest that can be used by Microsoft.Extensions.FileProviders.Embedded to preserve
     metadata of the files embedded in the assembly at compilation time.</Description>
     <TargetFramework>netstandard2.0</TargetFramework>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <IsShippingAssembly>true</IsShippingAssembly>
     <IsPackable>false</IsPackable>
     <IsImplementationProject>false</IsImplementationProject>

src/Framework/App.Ref.Internal/src/Microsoft.AspNetCore.App.Ref.Internal.csproj

@@ -7,7 +7,6 @@
     <PackageId>$(TargetingPackName).Internal</PackageId>
     <VersionPrefix>$(TargetingPackVersionPrefix)</VersionPrefix>
     <CopyBuildOutputToOutputDirectory>false</CopyBuildOutputToOutputDirectory>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <IncludeBuildOutput>false</IncludeBuildOutput>
     <IncludeSymbols>false</IncludeSymbols>
     <NoPackageAnalysis>true</NoPackageAnalysis>

src/Identity/Specification.Tests/src/Microsoft.AspNetCore.Identity.Specification.Tests.csproj

@@ -3,7 +3,6 @@
   <PropertyGroup>
     <Description>Shared test suite for Asp.Net Identity Core store implementations.</Description>
     <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <PackageTags>aspnetcore;identity;membership</PackageTags>
     <Nullable>disable</Nullable>
   </PropertyGroup>

src/Mvc/Mvc.Analyzers/src/Microsoft.AspNetCore.Mvc.Analyzers.csproj

@@ -4,10 +4,8 @@
     <PackageTags>aspnetcore;aspnetcoremvc</PackageTags>
     <!-- This package is for internal use only. It contains analyzers that are bundled in the .NET Core WebSDK. -->
     <IsShippingPackage>false</IsShippingPackage>
-
     <TargetFramework>netstandard2.0</TargetFramework>
     <IncludeBuildOutput>false</IncludeBuildOutput>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <NuspecFile>$(MSBuildProjectName).nuspec</NuspecFile>
   </PropertyGroup>
 

src/Mvc/Mvc.Api.Analyzers/src/Microsoft.AspNetCore.Mvc.Api.Analyzers.csproj

@@ -4,10 +4,8 @@
     <PackageTags>aspnetcore;aspnetcoremvc</PackageTags>
     <!-- This package is for internal use only. It contains analyzers that are bundled in the .NET Core WebSDK. -->
     <IsShippingPackage>false</IsShippingPackage>
-
     <TargetFramework>netstandard2.0</TargetFramework>
     <IncludeBuildOutput>false</IncludeBuildOutput>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <NuspecFile>$(MSBuildProjectName).nuspec</NuspecFile>
   </PropertyGroup>
 

src/Mvc/Mvc.Testing.Tasks/src/Microsoft.AspNetCore.Mvc.Testing.Tasks.csproj

@@ -2,8 +2,6 @@
   <PropertyGroup>
     <Description>Build tasks for functional tests.</Description>
     <TargetFramework>netstandard2.0</TargetFramework>
-
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <AddPublicApiAnalyzers>false</AddPublicApiAnalyzers>
     <IsPackable>false</IsPackable>
     <IsShipping>false</IsShipping>

src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj

@@ -12,7 +12,6 @@
     <RuntimeIdentifier>$(TargetRuntimeIdentifier)</RuntimeIdentifier>
     <DebugType>none</DebugType>
     <CopyBuildOutputToOutputDirectory>false</CopyBuildOutputToOutputDirectory>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <IsProjectReferenceProvider>false</IsProjectReferenceProvider>
     <TargetsForTfmSpecificBuildOutput>
       $(TargetsForTfmSpecificBuildOutput);

src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj

@@ -4,9 +4,7 @@
     <title>ASP.NET Core Logging Integration</title>
     <Description>This site extension enables logging integration for ASP.NET Core applications on Azure App Service.</Description>
     <TargetFramework>$(DefaultNetFxTargetFramework)</TargetFramework>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <PackageTags>aspnet;logging;aspnetcore;AzureSiteExtension;keyvault;configuration;dataprotection</PackageTags>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <PackageType>AzureSiteExtension</PackageType>
     <NoPackageAnalysis>true</NoPackageAnalysis>
     <IncludeBuildOutput>false</IncludeBuildOutput>

src/SiteExtensions/LoggingBranch/Directory.Build.targets

@@ -12,8 +12,6 @@
     <!-- Manually control dependencies -->
     <DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
     <!-- There is no documentation  -->
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <!-- There is no documentation  -->
     <RunPackageAnalysis>false</RunPackageAnalysis>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
   </PropertyGroup>

src/SiteExtensions/LoggingBranch/LB.csproj

@@ -4,7 +4,6 @@
     <title>ASP.NET Core Extensions</title>
     <Description>This extension enables additional functionality for ASP.NET Core on Azure WebSites, such as enabling Azure logging.</Description>
     <TargetFramework>$(DefaultNetFxTargetFramework)</TargetFramework>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <PackageTags>aspnet;logging;aspnetcore;AzureSiteExtension;keyvault;configuration;dataprotection</PackageTags>
     <ContentTargetFolders>content</ContentTargetFolders>
     <PackageId>Microsoft.AspNetCore.AzureAppServices.SiteExtension.$(AspNetCoreMajorMinorVersion).$(TargetArchitecture)</PackageId>
@@ -16,7 +15,6 @@
     <IncludeSymbols>false</IncludeSymbols>
     <NoSemVer20>true</NoSemVer20>
     <IsShippingPackage>false</IsShippingPackage>
-
     <!-- No source files -->
     <NoWarn>$(NoWarn);CS2008</NoWarn>
   </PropertyGroup>

src/SiteExtensions/Runtime/Directory.Build.targets

@@ -12,8 +12,6 @@
     <!-- The only build output of a pkgproj is the project -->
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <!-- There is no documentation  -->
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <!-- There is no documentation  -->
     <RunPackageAnalysis>false</RunPackageAnalysis>
 
   </PropertyGroup>

src/Tools/SDK-Analyzers/Components/src/Microsoft.AspNetCore.Components.SdkAnalyzers.csproj

@@ -4,7 +4,6 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <IncludeBuildOutput>false</IncludeBuildOutput>
     <NoPackageAnalysis>true</NoPackageAnalysis>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <Description>Roslyn analyzers for ASP.NET Core Components.</Description>
     <RootNamespace>Microsoft.AspNetCore.Components.Analyzers</RootNamespace>
     <!-- This package is for internal use only. It contains a CLI which is bundled in the .NET Core SDK. -->