Use Kind Artifact metadata and minor improvements to Signing/Publishing.props #60967
+28
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
mmitche
reviewed
Mar 17, 2025
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.deb" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.rpm" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.tar.gz" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.exe" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> |
There was a problem hiding this comment.
These look like they're duplicated with the ones on lines 49-50....Do they both add to the _InstallsToPublish?
There was a problem hiding this comment.
Not a duplicate. The lines in 49-50 glob the "artifacts\installers" directory. AspNetCore puts their installers into that directory.
mmitche
reviewed
Mar 17, 2025
eng/Signing.props
Outdated
| <ItemsToSign Include="$(VisualStudioSetupOutputPath)**\*.vsix" /> | ||
| <ItemsToSign Include="$(ArtifactsDir)installers\$(Configuration)\**\*.exe" /> | ||
| <ItemsToSign Include="$(ArtifactsDir)installers\$(Configuration)\**\*.msi" /> | ||
| <ItemsToSign Include="$(ArtifactsDir)installers\$(Configuration)\**\*.zip" Exclude="$(ArtifactsDir)installers\$(Configuration)\**\*.wixpack.zip" /> |
There was a problem hiding this comment.
ItemsToSign needs to include the .wixpacks for the msi signing to work.
wtgodbe
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.