Exempt parameters resolved from DI from validation #61895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
captainsafia
added
area-minimal
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the handling of service-resolved parameters by excluding those marked with [FromServices] or resolved from dependency injection from the validation process. Key changes include:
- In ValidationEndpointFilterFactory.cs, a new check is added to bypass DI-resolved parameters.
- Test files have been updated to include cases for service parameters and to ensure generated validation info skips these parameters.
- The generated TypesParser now excludes parameters implementing IFromServiceMetadata during the extraction process.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Http/Routing/src/ValidationEndpointFilterFactory.cs | Excludes DI-resolved parameters from validation via added helper methods and comments. |
| src/Http/Http.Extensions/test/ValidationsGenerator/*.cs | Updates tests to cover new behavior for service parameters. |
| src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/Parsers/ValidationsGenerator.TypesParser.cs | Adjusts parsing logic to skip parameters using the IFromServiceMetadata convention. |
Comments suppressed due to low confidence (1)
src/Http/Routing/src/ValidationEndpointFilterFactory.cs:87
- Consider adding a comment here to explain how using OfType() effectively identifies DI-resolved parameters to aid future maintainability.
private static bool HasFromServicesAttribute(ParameterInfo parameterInfo) => parameterInfo.CustomAttributes.OfType<IFromServiceMetadata>().Any();
...n/Microsoft.AspNetCore.Http.ValidationsGenerator/Parsers/ValidationsGenerator.TypesParser.cs
Outdated
Show resolved
Hide resolved
…ionsGenerator/Parsers/ValidationsGenerator.TypesParser.cs Co-authored-by: Copilot <[email protected]>
This was referenced May 13, 2025
| foreach (var parameter in parameters) | ||
| { | ||
| // Skip attributes that implement the IFromServiceMetadata interface. | ||
| // These attributes are used for dependency injection (DI) purposes and do not require validation. | ||
| if (parameter.GetAttributes().Any(attr => attr.AttributeClass is not null && attr.AttributeClass.ImplementsInterface(fromServiceMetadataSymbol))) |
There was a problem hiding this comment.
Should also add a check for [FromKeyedServicesAttribute] (and test of course)
There was a problem hiding this comment.
Yep -- added a test to check for the [FromKeyedServices].
BrennanConroy
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve the handling of service-resolved parameters in ASP.NET Core's validation system. The updates ensure that parameters marked with
[FromServices]or resolved from the dependency injection (DI) container are excluded from validation.Fixes #61392
Fixes #61770