Skip to content

Add support for Redirect preserving method/body (HTTP 307 and 308) #9968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 6, 2019
Merged

Add support for Redirect preserving method/body (HTTP 307 and 308) #9968

merged 6 commits into from
May 6, 2019

Conversation

huysentruitw
Copy link
Contributor

Add support for Redirect preserving method/body (HTTP 307 and 308)

Addresses #2864

@Tratcher
Copy link
Member

Tratcher commented May 4, 2019

I'd rather make this an extension method here:
https://github.com/aspnet/AspNetCore/blob/master/src/Http/Http.Extensions/src/ResponseExtensions.cs

In hindsight we put too many trivial methods directly onto the HttpResponse that we then have to deal with in the derived implementations.

@davidfowl
Copy link
Member

Agreed

@huysentruitw
Copy link
Contributor Author

huysentruitw commented May 4, 2019 •
edited
Loading

Should I move the other 2 Redirect methods too? Would be a breaking change though.

@Tratcher
Copy link
Member

Tratcher commented May 4, 2019 •
edited
Loading

No, we avoid unnecessary breaking changes.

@huysentruitw
Copy link
Contributor Author

Moved + added a unit-test.

@analogrelay analogrelay added this to the 3.0.0-preview6 milestone May 6, 2019
Tratcher
Tratcher approved these changes May 6, 2019
View reviewed changes
@analogrelay
Copy link
Contributor

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=180954

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2267
https://github.com/aspnet/AspNetCore-Internal/issues/2181

@Tratcher Tratcher merged commit e436fd9 into dotnet:master May 6, 2019
@Tratcher
Copy link
Member

Tratcher commented May 6, 2019

Thanks

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
3.0.0-preview6
Development

Successfully merging this pull request may close these issues.
7 participants
@huysentruitw @Tratcher @davidfowl @analogrelay @aspnet-hello @Eilon @amcasey