This repository was archived by the owner on Jul 12, 2022. It is now read-only.
Disable table formatting by default #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the behavior of the formatter to not define DOTNET_FORMATTER by default. It can be opted into by using the /tables option. The reason for this change is to avoid a bug in Roslyn around changing and resetting the parser options. When hit Roslyn will end up changing all files in the solution to have a different encoding / line ending. I haven't yet tracked down this bug but short term making this opt-in behavior so users aren't adversely affected by it.
The unit tests which depend on table formatting need to enable that feature before running.
The command line parsing code didn't reflect the current state of the tool. The <rule types> switch for instance was only used to add in the xUnit conversion rules which are no longer a part of the code style tool. This and some other dead code was removed and it now reflects the real feature set of the tool.
There really isn't a reason to print out the times for every file in a default run.
jaredpar
added a commit
that referenced
this pull request
Feb 27, 2015
Disable table formatting by default
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of the formatter to not define
DOTNET_FORMATTER by default. It can be opted into by using the /tables
option.
The reason for this change is to avoid a bug in Roslyn around changing
and resetting the parser options. When hit Roslyn will end up changing
all files in the solution to have a different encoding / line ending.
I haven't yet tracked down this bug but short term making this opt-in
behavior so users aren't adversely affected by it.