-
Notifications
You must be signed in to change notification settings - Fork 815
FSI multi-emit unstable #18441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Turns out this is not new. To fix probably we could uniquely name the generated assemblies for each session, e.g. FSI-ASSEMBLY, FSI-ASSEMBLY1, FSI-ASSEMBLY2 and so on. |
related #16118 The issue is that in tests we also have fsi sessions running concurrently but some of them are single-emit. All of them install a AssemblyResolve handler in the AppDomain. fsharp/src/Compiler/Interactive/fsi.fs Lines 3293 to 3294 in 2598fb1
and we get a TypeLoadException .
|
We know of people embedding fsi scripting in their respective apps. |
Some recently merged change made FSI multi-emit tests flaky:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1003058&view=ms.vss-test-web.build-test-results-tab&runId=26764208&resultId=104454&paneView=debug
Repro steps
Run
Scripting
tests in VS Test Explorer in parallel. Tests withuseMultiEmit: true
will fail.This apparently happens when running multiple evaluation sessions concurrently when one of the sessions is single-emit, so impact is low.
The text was updated successfully, but these errors were encountered: