Fix mixed emit-multi+/- sessions #18465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
2 tasks
T-Gro
approved these changes
Apr 10, 2025
|
/run fantomas |
|
Failed to run fantomas: https://github.com/dotnet/fsharp/actions/runs/14401636365 |
|
/run fantomas |
KevinRansom
force-pushed
the
emitmulti
branch
2 times, most recently
from
8a756ec to
521d8c4
Compare
abonie
approved these changes
May 5, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18441
The issue is caused because multi-emit+ and multi-emit- use the same name for the assembly: multi-emit- uses a dynamic assembly named FSIASSEMBLY and multi-emit+ uses multiple memory assemblies named FSIASSEMBLY with a new version for each submission.
When a type can't be found the magic resolver does a simple name search on assemblies looking for the missing type and finds the dynamic assembly.
The fix is to use a different assembly name for multi and single.