Add KeywordString to SynConst.

[nojaf]

Fixes #11477.

[cartermp]

Thanks!

[KevinRansom]

@nojaf -- KeywordString doesn't really mean anything to me, and naming is the hardest problem in computer science.

Would perhaps SourceIdentifier be better, I note that the documentation for C# calls those values: source-line-file-path-identifiers
https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/source-line-file-path-identifiers

Just a thought, I really don't want to bikeshed.

[nojaf]

Hey Kevin, I'm totally ok with a different name.

[KevinRansom]

Once the baseline is updated this will be good to go.

Thanks

[nojaf]

Thanks, forgot about SurfaceAreaTest indeed.

[KevinRansom]

@nojaf , thanks mate, it gets me every single time :-)

[alfonsogarciacaro]

After updating Fable with latest FCS code I'm getting problems when passing __SOURCE_DIRECTORY__ as static parameter. Example:

open Zanaptak.TypedCssClasses

type Css = CssClasses<"./style.module.css", Naming.PascalCase, resolutionFolder=__SOURCE_DIRECTORY__>

Error in Fable logs:

Invalid static argument to provided type. Expected an argument of kind 'string'. (code 3045)

Can it be related to this?

[nojaf]

Possibly, the AST for this does indeed use the new SynConst.

StaticConstantNamed
                              (LongIdent
                                 (LongIdentWithDots ([resolutionFolder], [])),
                               StaticConstant
                                 (SourceIdentifier
                                    ("__SOURCE_DIRECTORY__",
                                     "/workspace/fantomas-tools/src/server/ASTViewer/bin/output",
                                     tmp.fsx (3,80--3,100) IsSynthetic=false),
                                  tmp.fsx (3,80--3,100) IsSynthetic=false),
                               tmp.fsx (3,63--3,100) IsSynthetic=false)

[alfonsogarciacaro]

Ah, sorry. I just realized this was fixed by #11610, we just need to pull the latest changes in Fable.