Include range of attributes in parent (implementation files) #11495
Conversation
| @@ -651,11 +651,11 @@ type T() = | |||
| """ | |||
| => [ (2, 5, 11, 12), (2, 7, 11, 12) | |||
| (3, 4, 4, 12), (3, 7, 4, 12) | |||
| (3, 4, 4, 12), (4, 8, 4, 12) | |||
| (3, 4, 4, 12), (3, 10, 4, 12) | |||
There was a problem hiding this comment.
@auduchinok I winged this test a bit 😅.
In the parser I updated the range of SynMemberDefn.Member(SynBinding (None, SynBindingKind.Normal, false, false, $1, grabXmlDoc(parseState, 3), valSynData, declPat, None, expr, mWholeBindLhs, DebugPointAtBinding.NoneAtInvisible), m) (see line 1988) to only included the lhs of the SynBinding and not the entire range m.
This is the case with all the other SynBindings, so I thought I could fix this and make it consistent.
So, that leads to a change in getOutliningRanges (in ServiceStructure.fs) where at this point I'm not really sure what I did is correct. Any thoughts here?
There was a problem hiding this comment.
We ignore some of these ranges in ServiceStructure in Rider, and from a glance it looks like it won't affect us. Not sure about other users, though.
nojaf
force-pushed
the
include-range-attributese
branch
2 times, most recently
from
0de1c85 to
555a5f3
Compare
|
Ready for review. |
nojaf
force-pushed
the
include-range-attributese
branch
from
555a5f3 to
de3588c
Compare
nojaf
force-pushed
the
include-range-attributese
branch
from
de3588c to
5cd90a9
Compare
|
I believe this should also fix a problem in the quick fixer that removes unused bindings where the attribute(s) could be left dangling. |
Fixes #11486.
In this PR I tried to take attributes into account when constructing the range of SynBinding and others.
Most likely some tests outside of FCS might break due to corrected ranges.
I'll tackle those if they pop up.