Skip to content

fix records in multiemit #12889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2022
Merged

fix records in multiemit #12889

merged 3 commits into from
Apr 1, 2022

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Mar 28, 2022

Fixes the regression here: #12886

Also deletes tests/fsharp/core/printing/*.txt files which should never have been added

@dsyme
Copy link
Contributor Author

dsyme commented Mar 28, 2022

Heisen failure:

Processing D:\a\_work\1\s\global.json
Move-Item : Access to the path 'C:\Users\cloudtest\.netcoreeng\native\bin\perl\5.32.1.1.tmp' is denied.
At D:\a\_work\1\s\eng\common\native\CommonLibrary.psm1:382 char:5
+     Move-Item -Path $TempOutputDirectory -Destination $OutputDirector ...
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : WriteError: (C:\Users\cloudt...rl\5.32.1.1.tmp:DirectoryInfo) [Move-Item], IOException
    + FullyQualifiedErrorId : MoveDirectoryItemIOError,Microsoft.PowerShell.Commands.MoveItemCommand
 
at <ScriptBlock>, D:\a\_work\1\s\eng\common\native\install-tool.ps1: line 103
at <ScriptBlock>, D:\a\_work\1\s\eng\common\init-tools-native.ps1: line 103
at <ScriptBlock>, D:\a\_work\1\s\eng\common\init-tools-native.ps1: line 80
at InitializeNativeTools, D:\a\_work\1\s\eng\common\tools.ps1: line 638
at <ScriptBlock>, D:\a\_work\1\s\eng\build.ps1: line 446
at <ScriptBlock>, <No file>: line 1
Cannot find path 'C:\Users\cloudtest\.netcoreeng\native\bin\perl\5' because it does not exist.
perl installation failed
Native tools: 
Cannot bind argument to parameter 'Path' because it is an empty string.
System.Management.Automation.ParameterBindingValidationException: Cannot bind argument to parameter 'Path' because it is an empty string.
   at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)

@dsyme
Copy link
Contributor Author

dsyme commented Mar 30, 2022

@vzarytovskii @KevinRansom This is ready

@dsyme dsyme enabled auto-merge (squash) March 31, 2022 13:27
@dsyme
Copy link
Contributor Author

dsyme commented Apr 1, 2022

@vzarytovskii @KevinRansom approve on this please? And we should make sure it gets into 17.2 (I think the integrations are still automatic, but please double check)

@dsyme dsyme merged commit 40314e9 into dotnet:main Apr 1, 2022
@vzarytovskii
Copy link
Member

@vzarytovskii @KevinRansom approve on this please? And we should make sure it gets into 17.2 (I think the integrations are still automatic, but please double check)

I recall @brettfo disabling automatic merges yesterday, not sure it got merged already.

dsyme added a commit that referenced this pull request Apr 4, 2022
* fix records in multiemit

* fix build

* fix test
dsyme added a commit that referenced this pull request Apr 4, 2022
* fix records in multiemit

* fix build

* fix test
charlesroddie pushed a commit to charlesroddie/fsharp that referenced this pull request May 2, 2023
* fix records in multiemit

* fix build

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants