Fix for subtype pattern matching #13178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
dsyme
changed the title
vzarytovskii
approved these changes
May 23, 2022
|
@vzarytovskii Could you take a careful look at this (and the subsequent 6 functions) and see if there are obvious test cases/matrix that we should add? I think I need more eyes on the test matrix for this. |
We can merge this and add the tests separately |
Agree, we should merge this one, while I'm looking at some more potential tests. |
This unfortunately needs to be a priority for all servicable branches that have the problem... |
vzarytovskii
pushed a commit
to vzarytovskii/fsharp
that referenced
this pull request
May 24, 2022
* tentative fix for pattern matching logic * add test matrix
vzarytovskii
added a commit
that referenced
this pull request
May 24, 2022
* tentative fix for pattern matching logic * add test matrix Co-authored-by: Don Syme <[email protected]>
|
dev17.2 PR is here - #13190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13175
Added a systematic test matrix