Skip to content

Tests: Fix flaky AssemblyVersion tests #18268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Jan 25, 2025

These tests depend on a 30 sec time window, which apparently is too tight for parallel test execution.

The fix adds the two tests to NotThreadSafeResourceCollection, so they run separately and sequentially.

I also added a mention about parallelism in xUnit tests in the DEVGUIDE.

@majocha majocha requested a review from a team as a code owner January 25, 2025 11:58
Copy link
Contributor

✅ No release notes required

@T-Gro T-Gro enabled auto-merge (squash) January 27, 2025 09:48
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jakub :)

@T-Gro T-Gro merged commit a3bf3c9 into dotnet:main Jan 27, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants