-
Notifications
You must be signed in to change notification settings - Fork 815
Type checker: don't suppress errors while checking expressions #18311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❗ Release notes required
|
Well - 11 tests, that's much less than I would have expected here :) |
e025765
to
a8c081a
Compare
Could someone please help me with updating the baselines here? I've tried committing the files produced during the local tests run, but it doesn't seem to succeed on CI. |
This does not look like a baseline issue, all the CI runs today had these failures. EDIT: sorry, forget that, seems to be different |
Could someone please help me with updating the baselines here? I've tried committing the files produced during the local tests run, but it doesn't seem to succeed on CI. |
Hi @auduchinok sorry for the long delay here. I finally got to this - I pushed the changes and it's all green now. You were actually close. The thing is - there are 2 kinds of baselines here, .bsl and .vsbsl - and this test required adding the latter. Don't ask me why it's like this... artifacts of earlier testing approaches, you know. |
@psfinaki Thank you very much! |
The tests seem to fail because of #4516. I wish we could finally fix it and not create workarounds in the tooling and tests. |
This is ready. There was some difference between the local run and the CI in how the overload resolution error is reported. This could be because of how FCS tests build project options, which may be somewhat different from the CI. I've removed the diagnostic messages from the new tests for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks!
Fixes #17787.
I guess many tests may need to be updated. 🙂