Skip to content

Make unused bindings an error #18421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 31, 2025
Merged

Make unused bindings an error #18421

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ba1dfbd
reenable unused binding detection
T-Gro Mar 27, 2025
d0ca444
fantomas
T-Gro Mar 27, 2025
2b9ad2f
vsintegration/tests - ignored unused bindings in selected test projects
T-Gro Mar 27, 2025
0ab310c
Update FSharpBuild.Directory.Build.props
T-Gro Mar 27, 2025
81b4d0a
Merge branch 'main' into re-enable-unused-bindings-warning
T-Gro Mar 27, 2025
b345b6b
lexyac
T-Gro Mar 27, 2025
36f9d56
satisfy build
T-Gro Mar 27, 2025
cfa965e
one more ignore
T-Gro Mar 28, 2025
da0b7ed
Update FSharp.Compiler.Service.Tests.fsproj
T-Gro Mar 28, 2025
d86783b
VS FSI has too many unused bindings...
T-Gro Mar 31, 2025
6ba0ec3
another
T-Gro Mar 31, 2025
b989d60
and salsa..
T-Gro Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update FSharpBuild.Directory.Build.props
  • Loading branch information
@T-Gro
T-Gro committed Mar 27, 2025
commit 0ab310c4087748faa116e98ab9eb8c67db0a987e
2 changes: 1 addition & 1 deletion FSharpBuild.Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<ProtoOutputPath>$(ArtifactsDir)\Bootstrap</ProtoOutputPath>
<ValueTupleImplicitPackageVersion>4.4.0</ValueTupleImplicitPackageVersion>
<WarnOn>$(WarnOn);1182</WarnOn>
<WarningsAsErrors>0025;$(WarningsAsErrors)</WarningsAsErrors>
<WarningsAsErrors>1182;0025;$(WarningsAsErrors)</WarningsAsErrors>
<OtherFlags>$(OtherFlags) --nowarn:3384</OtherFlags>
<OtherFlags>$(OtherFlags) --times --nowarn:75</OtherFlags>
<OtherFlags Condition="$(AdditionalFscCmdFlags) != ''">$(OtherFlags) $(AdditionalFscCmdFlags)</OtherFlags>
Expand Down