Skip to content

Fix for #18433 (internal error during xml comment processing) #18436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

Martin521
Copy link
Contributor

@Martin521 Martin521 commented Apr 2, 2025

Description

Fixes #18433

Remarks

Initially, I wanted to replace the internal error by a warning.
However, the internal error only occurs

So, I settled for just ignoring the repeated xml comments for the same line.
Note that an xml comment will be lost only if it is (according to the line directives) on the same line as another one AND it is different from the other one. Which really does not make sense for any of the scenarios that line directives are meant for.
(Also, implemention-wise, getting to the range for a warning would have been quite complicated.)

Checklist

  • Test cases added
  • Release notes entry updated

Copy link
Contributor

github-actions bot commented Apr 2, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Apr 3, 2025
@T-Gro T-Gro merged commit b1490e3 into dotnet:main Apr 3, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Internal error when compiling contents with #line and triple-slash /// comments
3 participants