Consolidate SynExpr.LetOrUseBang(isUse= true)
#18472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarfgp
changed the title
SynExpr.LetOrUseBang patterns with isUse = trueSynExpr.LetOrUseBang patterns with isUse = true
|
edgarfgp
changed the title
SynExpr.LetOrUseBang patterns with isUse = trueSynExpr.LetOrUseBang(isUse = true)
edgarfgp
added
the
NO_RELEASE_NOTES
edgarfgp
changed the title
SynExpr.LetOrUseBang(isUse = true)SynExpr.LetOrUseBang(isUse= true)
T-Gro
approved these changes
Apr 16, 2025
psfinaki
approved these changes
Apr 16, 2025
abonie
approved these changes
Apr 16, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
3 tasks
T-Gro
added a commit
that referenced
this pull request
Apr 24, 2025
* Consolidated two `SynExpr.LetOrUseBang` patterns with `isUse = true` (#18472) * `and!` support in TaskBulder (#18451) * Update package Category (#18479) * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250423.3 (#18494) Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.25209.1 -> To Version 9.0.0-alpha.1.25223.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> --------- Co-authored-by: Edgar Gonzalez <[email protected]> Co-authored-by: Vladimir Shchur <[email protected]> Co-authored-by: Matt Mitchell <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While investigating/fixing #16343 the related logic was hard to follow because the
use!cases where split into multiple match clauses.This PR:
Unifies the
SynExpr.LetOrUseBang(isUse = true)logic in to a single case.Adds a
requireBuilderMethodfunctionChecklist