Skip to content

Define solution file to build in Build.props #18475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ViktorHofer
Copy link
Member

Build.props is the Arcade extension point to define which projects should get built. Move the define out of DotNetBuild.props so that eventually, that indirection (DotNetBuild.props) can get removed.

Description

Fixes # (issue, if applicable)

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

Build.props is the Arcade extension point to define which projects should get built. Move the define out of DotNetBuild.props so that eventually, that indirection (DotNetBuild.props) can get removed.
Copy link
Contributor

✅ No release notes required

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Apr 14, 2025
@ViktorHofer ViktorHofer marked this pull request as draft April 14, 2025 10:45
@ViktorHofer
Copy link
Member Author

This needs more work as contrary to other repos, fsharp defines the solution file to build in their scripts instead of in Arcade's Build.proj via a Build.props file.

@T-Gro
Copy link
Member

T-Gro commented Apr 25, 2025

@ViktorHofer : We can close this now, right?

@ViktorHofer
Copy link
Member Author

Yes, right.

@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Apr 25, 2025
@ViktorHofer ViktorHofer deleted the DefineSolutionBuildInArcadeExtensionPoint branch April 25, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants