Skip to content

[automated] Merge branch 'main' => 'release/dev18.0' #18501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

github-actions[bot]
Copy link
Contributor

I detected changes in the main branch which have not been merged yet to release/dev18.0. I'm a robot and am configured to help you automatically keep release/dev18.0 up to date, so I've opened this PR.

This PR merges commits made on main by the following committers:

  • T-Gro
  • ViktorHofer

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout main
git pull --ff-only
git checkout release/dev18.0
git pull --ff-only
git merge --no-ff main

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/fsharp HEAD:merge/main-to-release/dev18.0
or if you are using SSH
git push [email protected]:dotnet/fsharp HEAD:merge/main-to-release/dev18.0

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-release/dev18.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.

git fetch
git checkout -b merge/main-to-release/dev18.0 origin/release/dev18.0
git pull https://github.com/dotnet/fsharp merge/main-to-release/dev18.0
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/fsharp HEAD:merge/main-to-release/dev18.0
or if you are using SSH
git fetch
git checkout -b merge/main-to-release/dev18.0 origin/release/dev18.0
git pull [email protected]:dotnet/fsharp merge/main-to-release/dev18.0
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet/fsharp HEAD:merge/main-to-release/dev18.0

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

ViktorHofer and others added 2 commits April 24, 2025 15:40
…18491)

* Fix overbuilding fsharp & define solution to build in script

FSharp was building two solutions in the VMR on Windows which resulted
in the inner-build building the same thing but in parallel. The builds
each take 7-8 minutes. Fix that by introducing a productBuild switch
(which is already exposed in the Arcade scripts) and condition
which solution to build on it or the existing source-build switch.

Remove the /p:Projects property from DotNetBuild.props.

* proto fix

* Fix repo source-build

* Fixes

* fix

* Add YML test fix

* try

* fix200

* Fix201

* Update azure-pipelines-PR.yml

* Fixesss
@T-Gro T-Gro enabled auto-merge April 24, 2025 16:21
Copy link
Contributor Author

✅ No release notes required

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Apr 24, 2025
@T-Gro T-Gro merged commit e8bfd35 into release/dev18.0 Apr 24, 2025
33 checks passed
@ViktorHofer ViktorHofer deleted the merge/main-to-release/dev18.0 branch April 24, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants