Checker: don't capture environment for checked modules #18519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
Warning No PR link found in some release notes, please consider adding it.
|
|
OK, this approach seems to work. Since we only seem to want these captured environments in the IDE features (and they seem to break things there), I wonder what if we never add them. I've pushed another commit just to check it. |
|
This is ready. |
auduchinok
changed the title
edgarfgp
approved these changes
Apr 29, 2025
T-Gro
approved these changes
Apr 29, 2025
abonie
approved these changes
Apr 30, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18518.
This PR prevents adding the environment for the checked module.