opt-in warning attribute not valid for union case with fields #18532
Conversation
edgarfgp
changed the title
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
| TcAttributes cenv env target synAttrs | ||
| else | ||
| TcAttributes cenv env AttributeTargets.UnionCaseDecl synAttrs | ||
| let attrs = TcAttributes cenv env AttributeTargets.UnionCaseDecl synAttrs |
There was a problem hiding this comment.
Here we roll back to allow AttributeTargets.Method ||| AttributeTargets.Property as valid targets for union cases regardless the layout like before.
| // If the union case has fields, and the target is not AttributeTargets.Method || AttributeTargets.All. Then we raise a separate opt-in warning | ||
| let targetEnum = enum<AttributeTargets> target | ||
| if targetEnum <> AttributeTargets.Method && targetEnum <> AttributeTargets.All then | ||
| warning(Error(FSComp.SR.tcAttributeIsNotValidForUnionCaseWithFields(), id.idRange))) |
There was a problem hiding this comment.
This will only be raised of the user opts-in for this warning.
Description
Continuation of #18492
Related: #18298
Checklist