Skip to content

Include FSharp pre-release packages in the SDK transport package #18701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 24, 2025
Merged

Include FSharp pre-release packages in the SDK transport package #18701

merged 9 commits into from
Jun 24, 2025

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jun 19, 2025 •
edited by T-Gro
Loading

  • Enable the SDK to publish the stable-preview packages
  • Add a pre-release iteration so that previews can be differentiated.
  • Remove the version substitution in the shims project. There was no replacement happening.

@mmitche
Include FSharp pre-release packages in the SDK transport package
9129f5a 
- Enable the SDK to publish the stable-preview packages
- Add a pre-release iteration so that previews can be differentiated.
- Remove the version substitution in the shims project. There was no replacement happening.
@mmitche mmitche requested a review from a team as a code owner June 19, 2025 02:46
@mmitche mmitche requested a review from T-Gro June 19, 2025 02:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@mmitche mmitche mentioned this pull request Jun 19, 2025
Closed
T-Gro
T-Gro reviewed Jun 19, 2025
View reviewed changes
T-Gro
T-Gro reviewed Jun 19, 2025
View reviewed changes
T-Gro
T-Gro reviewed Jun 19, 2025
View reviewed changes
T-Gro
T-Gro reviewed Jun 19, 2025
View reviewed changes
T-Gro
T-Gro reviewed Jun 19, 2025
View reviewed changes
@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jun 20, 2025
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Jun 20, 2025
@T-Gro T-Gro requested a review from baronfel June 20, 2025 09:05
@T-Gro
Copy link
Member

T-Gro commented Jun 20, 2025

@baronfel : Can I ask for your feedback/review here, too? Can this affect any direct package consumers (and if positively, should we publish that info?)

@mmitche mmitche mentioned this pull request Jun 20, 2025
Open
T-Gro
T-Gro reviewed Jun 23, 2025
View reviewed changes
T-Gro
T-Gro reviewed Jun 23, 2025
View reviewed changes
@mmitche
Copy link
Member Author

mmitche commented Jun 23, 2025

@baronfel let me know what you think.

@baronfel
Copy link
Member

I'm not up-to-speed on what the goal is here, so I don't know what kind of feedback I can offer. Is this just getting F# on the same .NET 10-preview-branded package version as many of the other SDK-delivered packages?

@mmitche
Copy link
Member Author

mmitche commented Jun 24, 2025 •
edited
Loading

@baronfel Aligning the pre-release labels of the FSharp packages, and aligning with .NET:

https://www.nuget.org/packages/FSharp.Core/#versions-body-tab - Used "beta" without pre-release iteration
https://www.nuget.org/packages/FSharp.Compiler.Service/43.10.100-preview.25277.114 - Used 'preview' without pre-release iteration.

Both would align on 'previewN' now.

@baronfel
Copy link
Member

Oh that's perfect.

@T-Gro T-Gro enabled auto-merge (squash) June 24, 2025 08:34
@T-Gro T-Gro merged commit fc212af into dotnet:release/dev18.0 Jun 24, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@baronfel baronfel Awaiting requested review from baronfel

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmitche @T-Gro @baronfel