Skip to content

Suggestions for misspelled values, namespaces, attributes, functions and more - fixes #1909 #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 16, 2016
Merged

Suggestions for misspelled values, namespaces, attributes, functions and more - fixes #1909 #1911

merged 17 commits into from
Dec 16, 2016

Conversation

forki
Copy link
Contributor

@forki forki commented Dec 1, 2016

image

@forki forki mentioned this pull request Dec 1, 2016
Closed
@forki forki changed the title Suggestions for mispelled values - fixes #1909 WIP Suggestions for mispelled values - fixes #1909 Dec 2, 2016
@forki forki force-pushed the i1909 branch 2 times, most recently from b6cb35a to cddec5a Compare December 2, 2016 12:38
@forki
Copy link
Contributor Author

forki commented Dec 2, 2016

image

@forki forki force-pushed the i1909 branch 6 times, most recently from 577352f to d31c279 Compare December 4, 2016 10:20
@forki
Copy link
Contributor Author

forki commented Dec 4, 2016 •
edited
Loading

I'm making good progress here, but this is also dependend on @Rickasaurus's jaro-winkler impl. So please don't merge before you merge #1945

@forki forki mentioned this pull request Dec 4, 2016
Closed
@forki forki closed this Dec 5, 2016
@forki forki reopened this Dec 5, 2016
@forki forki force-pushed the i1909 branch 7 times, most recently from 7defcf3 to 8d91b96 Compare December 6, 2016 08:11
@forki forki changed the title WIP Suggestions for mispelled values - fixes #1909 Suggestions for mispelled values - fixes #1909 Dec 6, 2016
@forki
Copy link
Contributor Author

forki commented Dec 6, 2016

since #1945 is merged, this is ready for review.
It's already enabling suggestions in many many new places and I intend to keep working on int in new Pull Requests. But I think this is already very useful and I'd like to see it in.

@forki forki force-pushed the i1909 branch 2 times, most recently from ebffc9d to 6ee3a63 Compare December 7, 2016 16:05
@forki
Copy link
Contributor Author

forki commented Dec 16, 2016

Something weird happened @KevinRansom did you merge in wrong direction?

@forki
Copy link
Contributor Author

forki commented Dec 16, 2016

ok I rebased on master. let's see if that fixed things

@KevinRansom
Copy link
Contributor

I usually press squash and merge. But it looks like it went the wrong way

@forki
Copy link
Contributor Author

forki commented Dec 16, 2016 via email

@KevinRansom
Copy link
Contributor

@forki ...
ci_part1 error is unrelated to this pr.

@KevinRansom
Copy link
Contributor

@dotnet-bot test this please

@forki
Copy link
Contributor Author

forki commented Dec 16, 2016

ok loogs good now

@KevinRansom
Copy link
Contributor

Thanks for taking care of this

Kevin

@KevinRansom KevinRansom merged commit 97a3858 into dotnet:master Dec 16, 2016
@forki forki deleted the i1909 branch December 17, 2016 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@forki @dsyme @cartermp @vasily-kirichenko @Rickasaurus @KevinRansom @msftclas