Skip to content

create output directory for F# tensorflow estimator sample #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2019
Merged

create output directory for F# tensorflow estimator sample #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...rted/DeepLearning_TensorFlowEstimator/ImageClassification.Train/assets/outputs/README.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
output gets saved to this directory
Copy link
Contributor

@prathyusha12345 prathyusha12345 Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CESARDELATORRE we don't have this file in C# sample. I think the name outputs itself describes the output files. I feel no need to add this file. Cesar Please add your inputs.

Copy link
Contributor

@CESARDELATORRE CESARDELATORRE Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it so the folder gets created even if there's no model .ZIP file in there.. But I agree that this might not be needed. I'll merge it in any case. Thanks! 👍

Copy link
Contributor Author

@kevmal kevmal Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was only to force the directory to be created in the repo, following the example of other projects (for example outputs directory of customer segmentation). Though the usual message is typically

This folder is empty until you run the training console app and create/train and save the models as .ZIP files.
Those model .ZIP files should appear in this folder.

Alternatively, could add a .gitignore to force the directory or add a CreateDirectory to the code.